Add an option to Ignore hardware media button events

[NyanCatTW1]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• Adds an option called "Ignore hardware media button events", which disables any pause/play and the prev/next track buttons, including ones on a headset. It helps prevent accidental touches and makes the app more usable on a headset with broken buttons.

Before/After Screenshots/Screen Record

The option is inside the Video and audio category.

• Before:
  

• After:
  

Fixes the following issue(s)

• Fixes Add an option to disable prev/next track buttons on headsets #9745

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

• I read the contribution guidelines.

[Stypox]

Thanks! I don't think it's a good idea to add the BLUETOOTH_CONNECT permission. Unfortunately unless there is a different way to tell media button events apart, I don't think this will be merged.

[NyanCatTW1]

Actually, it seems like only hardware media events go through the custom handler. Therefore, it should be safe to just not distinguish them.
I will make the changes in two or three days

[Stypox]

Ok, thanks. So the setting description should be updated to explain that all hardware actions will be blocked (including bluetooth ones). Then it will be up to users to choose if they want to enable this setting or not.

[NyanCatTW1]

I made a mess with the git history on the fork, but it should be ready for preview now
It now ignores all events that go through the MediaButtonEventHandler, which should hopefully be exactly what's needed to achieve the desired behavior

[Stypox]

I pushed some improvements to make code shorter and a bit more performant. I tested with a bluetooth speaker and the hardware buttons get correctly blocked when the setting is on. Are the changes I pushed ok, in your opinion? Thanks!

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[NyanCatTW1]

Looks nice! So I suppose it's ready for merge now?

[Stypox]

Yes, thanks for confirming :-)