Directly startActivity without querying for default app
#9817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getDefaultAppPackageName does not work on Android 12. This fixes "No app can open this" messages.
Closed
6 tasks
|
Kudos, SonarCloud Quality Gate passed! |
|
what about the remaining usages of "getDefaultAppPackageName "? shouldn't this method be removed completely? |
Merged
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
getDefaultAppPackageNamedoes not work on Android 12: it always returns an empty string. We would need the permission to query all packages for that to work, but we definitely don't want to add such an invasive permission in NewPipe. This PR does not querygetDefaultAppPackageNameanymore before opening an intent, which fixes the "No app can open this" messages.I also removed the
toast_no_playerstring ("No app installed to play this file"), because it was basically a duplicate ofno_app_to_open_intent("No app on your device can open this").Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence