Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PeerTube] Fix comments info test #1034

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

AudricV
Copy link
Member

@AudricV AudricV commented Mar 4, 2023

A comment from which a part of its text was used in testGetCommentsFromCommentsInfo method of PeertubeCommentsExtractorTest.Default test class has been removed, so it couldn't be found in the comments list.

This comment has been replaced by a new one from the current comments of the video.

Also, in the parent class PeertubeCommentsExtractorTest, final has been also used as much as possible and for-each loops of lists have been replaced by their forEach method or the Stream API, in order to simplify code.

…tsExtractorTest.Default

The tested comment has been removed, so it couldn't be found in the comments
list.

This comment has been replaced by a new one from the current comments of the
video.

Also, in the parent class PeertubeCommentsExtractorTest, final has been used as
much as possible and for-each loops of lists have been replaced by their
forEach method or the Stream API, in order to simplify code.
@AudricV AudricV added the peertube service, https://joinpeertube.org/ label Mar 4, 2023
@TobiGr TobiGr merged commit 44ae139 into TeamNewPipe:dev Mar 20, 2023
@AudricV AudricV deleted the peertube-fix-commentsinfo-test branch March 20, 2023 18:36
@ShareASmile ShareASmile added the tests Issues and PR related to unit tests label Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
peertube service, https://joinpeertube.org/ tests Issues and PR related to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants