[YouTube] Fix ParsingException when comments are unavailable in a video #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue TeamNewPipe#969. Parsing exception is handled when the JSON path does not exist in the case of disabled comments.
AudricV
requested changes
Mar 14, 2023
There was a problem hiding this comment.
Thanks for this fix!
Please use appropriate PR and commit names in the future: do not repeat the issue title but describe what you did for both things (so in this case it would be something like "[YouTube] Fix ParsingException when getting comments on videos without comments").
.../java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsExtractor.java
Outdated
Show resolved
Hide resolved
.../java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeCommentsExtractor.java
Outdated
Show resolved
Hide resolved
AudricV
added
bug
…youtube/extractors/YoutubeCommentsExtractor.java Co-authored-by: Audric V. <[email protected]>
AudricV
approved these changes
Mar 30, 2023
AudricV
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #969. Parsing exception is handled when the JSON path does not exist in the case of disabled comments.
Fixes #969
The output is now
{"comments":[],"nextpage":null,"disabled":true}