Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract stream and search meta info for YouTube #451

Merged
merged 2 commits into from
Dec 22, 2020
Merged

Extract stream and search meta info for YouTube #451

merged 2 commits into from
Dec 22, 2020

Conversation

TobiGr
Copy link
Contributor

@TobiGr TobiGr commented Nov 1, 2020 •
edited
Loading

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Extract stream and search query meta data info which is provided by the service.
The meta info in distributed in two formats:

  • info panel
  • clarification renderer
info panel (stream)
The info panel mainly contains a short text (mostly one paragraph) and an link to the related Wikipedia article for more info.
clarification renderer (stream)
The clarification renderer has a title, a text, a button which links to an official site (e.g. WHO). In a section below, there can be more links. I've only seen links to Google search results about the topic. That's why I did not implement fetching these links.
clarification renderer (search)

ToDo

  • add tests for clarification renderer

@TobiGr TobiGr added the enhancement New feature or request label Nov 1, 2020
@TobiGr TobiGr mentioned this pull request Nov 1, 2020
Merged
5 tasks
@TobiGr TobiGr added the youtube service, https://www.youtube.com/ label Nov 1, 2020
Stypox
Stypox requested changes Nov 1, 2020
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why List<MetaInfo>? Will it ever happen that there is more than one meta info?

Wouldn't MetaInfos texts always be in English? They would then be useless for people who don't speak english

@TobiGr
Copy link
Contributor Author

TobiGr commented Nov 1, 2020 •
edited
Loading

Why List<MetaInfo>? Will it ever happen that there is more than one meta info?

It is possible that there are multiple info banners. E.g. I have seen that in a video about corona which was produced by a public broadcaster.

Wouldn't MetaInfos texts always be in English? They would then be useless for people who don't speak english

yes

@B0pol
Copy link
Member

B0pol commented Nov 1, 2020

Wouldn't MetaInfos texts always be in English?

In the current extractor version, yes. If we do requests in another language, it will be in that language.

@TobiGr TobiGr force-pushed the meta_info branch 2 times, most recently from daa6e98 to 7def8d8 Compare November 18, 2020 16:25
@TobiGr TobiGr requested a review from Stypox November 22, 2020 11:08
@TobiGr
Copy link
Contributor Author

TobiGr commented Nov 24, 2020

Tests should be good now. I also added a few null checks and made some vars final.

@TobiGr TobiGr force-pushed the meta_info branch 2 times, most recently from 5a0dc24 to f3764c5 Compare November 24, 2020 10:55
Stypox
Stypox requested changes Dec 12, 2020
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, I just pointed out some small issues ;-)

@TobiGr TobiGr force-pushed the meta_info branch 3 times, most recently from 79b5aa9 to 31a6fe1 Compare December 19, 2020 13:56
Stypox
Stypox requested changes Dec 20, 2020
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically ready

Stypox
Stypox approved these changes Dec 22, 2020
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :-D

@TobiGr TobiGr merged commit c682ea0 into dev Dec 22, 2020
@TobiGr TobiGr deleted the meta_info branch December 22, 2020 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stypox Stypox Stypox approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request youtube service, https://www.youtube.com/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TobiGr @B0pol @Stypox