Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PeerTube tests by changing instance #511

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Conversation

B0pol
Copy link
Member

@B0pol B0pol commented Jan 11, 2021

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API. no need

@TobiGr TobiGr added the peertube service, https://joinpeertube.org/ label Jan 11, 2021
@TobiGr
Copy link
Contributor

TobiGr commented Jan 14, 2021

@B0pol Is that ready to be merged? Looks good to me

@B0pol
Copy link
Member Author

B0pol commented Jan 14, 2021

It's WIP because all tests are not fixed but you can merge it if you want, or push fix for the other tests now (edits are available for maintainers).

@TobiGr
Copy link
Contributor

TobiGr commented Jan 14, 2021

I suggest to merge this, because it fixes PeerTube related tests and that is good enough for now

@TobiGr TobiGr changed the title Fix tests Fix PeerTube tests by changing instance Jan 14, 2021
@TobiGr TobiGr marked this pull request as ready for review January 14, 2021 18:14
@TobiGr TobiGr merged commit c2ff672 into TeamNewPipe:dev Jan 14, 2021
@TobiGr TobiGr mentioned this pull request Jan 18, 2021
14 tasks
@B0pol B0pol deleted the errors branch February 18, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
peertube service, https://joinpeertube.org/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants