Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore all failing tests #512

Merged
merged 1 commit into from
Jan 15, 2021
Merged

Conversation

XiangRongLin
Copy link
Collaborator

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Ignore all currently failing tests.
This way one finally can see again if the own changes broke something (additionally).
I'll unignore the ones where there are only minor string changes, when i adjust them to inject the mocks. The ones that are actually broken, have to be fixed by someone else in the future.

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree failing tests should be ignored, until proper mocked tests exist

@Stypox Stypox merged commit 588fbcc into TeamNewPipe:dev Jan 15, 2021
@XiangRongLin XiangRongLin deleted the ignore_failing branch January 15, 2021 19:37
@XiangRongLin
Copy link
Collaborator Author

@Stypox So much for ignoring failing tests. There are already new ones 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants