Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address clippy lints #30

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Conversation

danieleades
Copy link

No description provided.

@danieleades danieleades mentioned this pull request Apr 6, 2023
@That3Percent
Copy link
Owner

Thanks for your contribution @danieleades. After two years of stagnation, I'm probably not going to take time to review this. Though it's absolutely no fault of your own, it's the clippy PR that ultimately killed my motivation to work on this library for reasons that are psychological and personal. For context, I'm not really a fan of clippy or linters in general. There are a bunch of reasons for this that I've accumulated over the years but I'm not going to try to articulate them at this moment. I think the PR made working on this library feel more like a "responsibility" than a "gift". I wanted to review and merge this PR because I wanted to make you happy (whoever you are) and unblock your work, because my opinion on clippy is probably unpopular, because I felt that I "should" more than I wanted to. At the same time, I started going through a difficult situation that is likely to stay with me for the rest of my life. I no longer have free time. So, I can't afford to maintain a library for fun, much less for guilt. Cheers and I wish you well.

@danieleades
Copy link
Author

@That3Percent I'm sorry to hear that.

For what it's worth, I think it's a matter of perspective. I get a real sense of satisfaction squashing lints in my repos. Feels like I'm reducing the local entropy in the universe...

Good luck with your next endeavours!

@That3Percent
Copy link
Owner

@danieleades Thanks for understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants