Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sysvinit docs for toktok fork #10

Closed
wants to merge 2 commits into from
Closed

Update sysvinit docs for toktok fork #10

wants to merge 2 commits into from

Conversation

LittleVulpix
Copy link

@LittleVulpix LittleVulpix commented Jul 10, 2016

Update the manual to provide a command necessary to open <1024 ports for users on SysVinit


This change is Reviewable

"rebase" to toktok master
Update the manual to provide a command necessary to open <1024 ports for users on SysVinit
@GrayHatter
Copy link

@nurupo

@nurupo
Copy link
Member

nurupo commented Jul 10, 2016

Eh... do i have to write the same comment in two repos now?

What does epi stand for? I see some people using just ep for this, so I'm wondering. --nurupo

@LittleVulpix
Copy link
Author

@nurupo :

Capability Sets

Each thread has three capability sets containing zero or more of the above capabilities:

Effective - the capabilities used by the kernel to perform permission checks for the thread.

Permitted - the capabilities that the thread may assume (i.e., a limiting superset for the effective and inheritable sets). If a thread drops a capability from its permitted set, it can never re-acquire that capability (unless it exec()s a set-user-ID-root program).

inheritable - the capabilities preserved across an execve(2). A child created via fork(2) inherits copies of its parent's capability sets. See below for a discussion of the treatment of capabilities during exec(). Using capset(2), a thread may manipulate its own capability sets, or, if it has the CAP_SETPCAP capability, those of a thread in another process.

@nurupo
Copy link
Member

nurupo commented Jul 10, 2016

Well, looks good to me. There is better way of doing that, directly in C code, but I don't have time for that and this is good enough.

@nurupo
Copy link
Member

nurupo commented Jul 10, 2016

Hm, now i see why the high-five bot is useful. You can't access reviewable if you are not assigned to the issue. (@iphydf)

@GrayHatter
Copy link

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@GrayHatter
Copy link

@nurupo you mean @iphydf

@nurupo
Copy link
Member

nurupo commented Jul 10, 2016

@nurupo you mean @iphydf

Welp, highlighted the wrong person. Thanks, fixed.

Also, now I can access reviewable. Did someone change something for it to work?

@iphydf
Copy link
Member

iphydf commented Jul 11, 2016

Can you squash the commits? It's not very interesting in the history that you rebased on master.

@LittleVulpix
Copy link
Author

The reason I had to do this "rebase" is because I had to create a branch which acts as toktok/master for me, since I cannot fork your repo.... since I already have a fork of toxcore (github stuff).

I'm not sure how else to do this. I suppose you could also wait for toxcore to accept my PR and then I can get rid of toxcore fork in my repo, fork toktok, make the change there and then create a PR for toktok repo...

@LittleVulpix
Copy link
Author

see #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants