Prune long long warnings. #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
iphydf
requested changes
Aug 13, 2018
auto_tests/file_saving_test.c
Outdated
| @@ -87,7 +87,7 @@ static void load_data_decrypted(void) | |||
| uint8_t *cipher = (uint8_t *)malloc(size); | |||
| uint8_t *clear = (uint8_t *)malloc(size - TOX_PASS_ENCRYPTION_EXTRA_LENGTH); | |||
| size_t read_value = fread(cipher, sizeof(*cipher), size, f); | |||
| printf("Read read_vavue = %u of %ld\n", (unsigned)read_value, size); | |||
| printf("Read read_vavue = %u of %lu\n", (unsigned)read_value, (unsigned long)(size)); | |||
There was a problem hiding this comment.
Remove parentheses around size.
Note: only remove them in this instance. Don't remove them in any of the other casts in the other files.
|
@iphydf done (for some reason I didn't receive notification in e-mail). |
iphydf
approved these changes
Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In file_saving_test.c the size argument type is not size_t, but int64_t, so %zu is inadequate here.
This change is