Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests on Appveyor (Windows native build). #1199

Merged
merged 1 commit into from
Sep 23, 2018
Merged

Run tests on Appveyor (Windows native build). #1199

merged 1 commit into from
Sep 23, 2018

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Sep 22, 2018 •
edited
Loading

This change is Reviewable

@iphydf iphydf added this to the v0.2.x milestone Sep 22, 2018
@iphydf iphydf force-pushed the exec-tests-windows branch 2 times, most recently from 72dd2eb to 8e0a250 Compare September 22, 2018 23:16
@codecov
Copy link

codecov bot commented Sep 22, 2018 •
edited
Loading

Codecov Report

Merging #1199 into master will decrease coverage by <.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1199     +/-   ##
========================================
- Coverage    82.8%   82.7%   -0.1%     
========================================
  Files          82      82             
  Lines       14646   14646             
========================================
- Hits        12128   12114     -14     
- Misses       2518    2532     +14
Impacted Files Coverage Δ
toxav/audio.c 65.7% <0%> (-7.8%) ⬇️
toxav/msi.c 63.9% <0%> (-1.2%) ⬇️
toxav/toxav.c 67.7% <0%> (-0.5%) ⬇️
toxcore/net_crypto.c 93.4% <0%> (+0.5%) ⬆️
toxcore/LAN_discovery.c 85.8% <0%> (+2.8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c7c924...8bb5be3. Read the comment docs.

@iphydf iphydf force-pushed the exec-tests-windows branch 5 times, most recently from 10f81a1 to b653de4 Compare September 23, 2018 00:07
@iphydf
Run tests on Appveyor (Windows native build).
8bb5be3 
We ignore the errors for now.
sphaerophoria
sphaerophoria approved these changes Sep 23, 2018
View reviewed changes
Copy link

@sphaerophoria sphaerophoria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 approvals obtained (waiting on @sphaerophoria)

sphaerophoria
sphaerophoria approved these changes Sep 23, 2018
View reviewed changes
Copy link

@sphaerophoria sphaerophoria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 approvals obtained

sphaerophoria
sphaerophoria approved these changes Sep 23, 2018
View reviewed changes
Copy link

@sphaerophoria sphaerophoria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@iphydf iphydf merged commit 8bb5be3 into TokTok:master Sep 23, 2018
@iphydf iphydf deleted the exec-tests-windows branch September 23, 2018 09:55
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.8 Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sphaerophoria sphaerophoria sphaerophoria approved these changes

Assignees

@sphaerophoria sphaerophoria

Labels
None yet
Milestone
v0.2.8
Development

Successfully merging this pull request may close these issues.
3 participants
@iphydf @sphaerophoria @robinlinden