-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new WineHQ Debian package repository key #1284
Conversation
|
bb47f67
to
e7b4d70
Compare
Codecov Report
@@ Coverage Diff @@
## master #1284 +/- ##
========================================
+ Coverage 83.3% 83.3% +<.1%
========================================
Files 82 82
Lines 14869 14869
========================================
+ Hits 12388 12394 +6
+ Misses 2481 2475 -6
Continue to review full report at Codecov.
|
e7b4d70
to
fd08129
Compare
f47bcf8
to
ebf3a82
Compare
Windows builds: https://travis-ci.org/TokTok/c-toxcore/builds/475157088. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 approvals obtained (waiting on @robinlinden)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @robinlinden)
Please don't use unauthenticated packages in user scripts. It wouldn't be as bad if unauthenticated packages were used only in the CI as we don't provide any build artifacts there, but that script is also meant to be used by people to produce toxcore dlls through the cross-compilation, it's in the INSTALL.md instructions, it's not just for CI.
Anyway, the issue was that WineHQ has changed their package signing key:
(Full log)
You can see the notice about the key being changed on WineHQ website:
That's my primary source about the key change ^.
I have also faced this key change issue on my own system in December and given how no noise was raised over it for what is now several weeks, it does indeed appear like they simply have changed the key rather than that they got compromised. It would help if they have confirmed the key change on one more resource other than the website, but I couldn't find it being mentioned anywhere else.
I have also added a key fingerprint check in the script, because I figured that if the the package repository is compromised they might as well update the public key to match the signatures of compromised packages and we wouldn't know any better that the key has changed since we download the key every time we use the repository. (We have noticed the change only because they didn't overwrite the old
Release.key
key with the new one, they instead put it under the newwinehq.key
filename). Without that fingerprint check we might as well not bother using the key and use--allow-unauthenticated
, so this check is important to have.This change is