-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version-sync script. #166
Conversation
Doesn't changing the versions directly in the source files break the promise of out-of-tree building not to litter the source tree? e.g. if you build tox like |
This script won't change any source files unless you change the CMakeLists.txt file, in which case you break the promise yourself. This script just makes sure that if you change one place, the other places are also changed. |
I see, the source files would already have the versions set to the same values as in CMakeLists.txt file when someone git clones / gets a tarball, so changing them again to the same values would be a no-op. Actually, looking at the shell script, it won't even modify the original the file if versions didn't change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need a Pull to test formatting, you can ignore this
41af4c3
to
5f56be7
Compare
No patch commits :\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
5f56be7
to
41b54ba
Compare
This will update tox.in.h only. Currently, you will still need to manually update tox.h. An upcoming PR (TokTok#154) will update tox.h as part of the build.
41b54ba
to
36f40f1
Compare
This will update tox.in.h only. Currently, you will still need to
manually update tox.h. An upcoming PR (#154) will update tox.h as
part of the build.