fix: Correct a use-after-free and fix some memory leaks. #2488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iphydf
force-pushed
the
find-gtest
branch
10 times, most recently
from
3270d8f to
b98a063
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2488 +/- ##
==========================================
- Coverage 69.81% 68.96% -0.86%
==========================================
Files 75 89 +14
Lines 25999 27769 +1770
==========================================
+ Hits 18151 19150 +999
- Misses 7848 8619 +771 ☔ View full report in Codecov by Sentry. |
iphydf
force-pushed
the
find-gtest
branch
2 times, most recently
from
6a7038f to
5a1cfb4
Compare
Green-Sky
approved these changes
Dec 21, 2023
robinlinden
approved these changes
Dec 21, 2023
iphydf
changed the title
find_package to find gtest.
JFreegman
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
Reviewed 24 of 24 files at r1, all commit messages.
Reviewable status:complete! 3 of 1 approvals obtained
Also: use `find_package` to find gtest. This fixes the coverage build to include unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the coverage build to include unit tests.
This change is