fix: Zero out stack-allocated secret key before return. #2661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2661 +/- ##
==========================================
- Coverage 73.77% 73.70% -0.08%
==========================================
Files 148 148
Lines 30476 30478 +2
==========================================
- Hits 22485 22464 -21
- Misses 7991 8014 +23 ☔ View full report in Codecov by Sentry. |
nurupo
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
LGTM.
iphydf is no tool and leaving secret keys on the stack for someone else to read them later is a bad security practice indeed 👍
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
robinlinden
approved these changes
Feb 9, 2024
Issue found by iphydf (no tools for this, yet).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue found by iphydf (no tools for this, yet).
This change is