-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Release 0.2.19 #2691
chore: Release 0.2.19 #2691
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2691 +/- ##
==========================================
+ Coverage 73.07% 73.09% +0.02%
==========================================
Files 149 149
Lines 30533 30533
==========================================
+ Hits 22312 22319 +7
+ Misses 8221 8214 -7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! 3 of 1 approvals obtained
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be rebased on master, which will also fix some of the CI checks.
goblint says that this assertion always fails:
[Error][Assert] Assertion "(int )ret" will fail. (toxcore/group.c:3699:17-3699:38)
Lines 3696 to 3700 in 0ec4978
// HACK: suppress unused variable warning | |
if (!ret) { | |
// wipe_group_chat(...) must be able to wipe partially allocated groups | |
assert(ret); | |
} |
Typically one does (void)(foo);
to get rid of the unused variable warning, so not sure what is the code above is trying to do.
@iphydf didn't you want to mention in tox_events.h
and tox_dispatch.h
that those APIs are experimental / not yet stable? ("Experimental" is probably a bad choice of words given those headers get installed even with -DEXPERIMENTAL_API=OFF
.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iphydf didn't you want to mention in
tox_events.h
andtox_dispatch.h
that those APIs are experimental / not yet stable? ("Experimental" is probably a bad choice of words given those headers get installed even with-DEXPERIMENTAL_API=OFF
.)
I see @iphydf addressed those in #2743.
The goblint warning doesn't bother me too much so LGTM.
This change is