Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make friend message callback stateless #48

Merged
merged 1 commit into from
Aug 20, 2016

Conversation

GrayHatter
Copy link

@GrayHatter GrayHatter commented Aug 19, 2016

This change is Reviewable

@iphydf
Copy link
Member

iphydf commented Aug 19, 2016

:lgtm:


Review status: 0 of 9 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@iphydf
Copy link
Member

iphydf commented Aug 19, 2016

:lgtm_cancel: you need to update the apidsl file.


Review status: 0 of 9 files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@GrayHatter GrayHatter force-pushed the stateless_friend_msg branch 2 times, most recently from 5c40ba9 to 44f3b09 Compare August 19, 2016 22:46
@iphydf
Copy link
Member

iphydf commented Aug 19, 2016

Reviewed 4 of 9 files at r1.
Review status: 4 of 9 files reviewed at latest revision, 1 unresolved discussion.


testing/tox_shell.c, line 59 [r1] (raw file):

                   void *userdata)
{
    int master = *((int *)userdata);

This will now cause a null pointer dereference. You will want to pass the userdata master to tox_iterate.


Comments from Reviewable

@GrayHatter
Copy link
Author

Review status: 4 of 10 files reviewed at latest revision, 1 unresolved discussion.


testing/tox_shell.c, line 59 [r1] (raw file):

Previously, iphydf wrote…

This will now cause a null pointer dereference. You will want to pass the userdata master to tox_iterate.

Done.

Comments from Reviewable

@iphydf
Copy link
Member

iphydf commented Aug 19, 2016

:lgtm:


Reviewed 2 of 9 files at r1, 4 of 4 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@iphydf
Copy link
Member

iphydf commented Aug 20, 2016

Rebase, then I'll merge.

@GrayHatter GrayHatter force-pushed the stateless_friend_msg branch from 2929a77 to 1f94c96 Compare August 20, 2016 18:08
@iphydf
Copy link
Member

iphydf commented Aug 20, 2016

:lgtm:


Reviewed 6 of 6 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@iphydf iphydf merged commit 1f94c96 into TokTok:master Aug 20, 2016
@GrayHatter GrayHatter deleted the stateless_friend_msg branch August 20, 2016 18:15
@iphydf iphydf modified the milestone: v0.0.1 Nov 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants