-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make friend message callback stateless #48
Conversation
Review status: 0 of 9 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
Review status: 0 of 9 files reviewed at latest revision, all discussions resolved, some commit checks failed. Comments from Reviewable |
5c40ba9
to
44f3b09
Compare
Reviewed 4 of 9 files at r1. testing/tox_shell.c, line 59 [r1] (raw file):
This will now cause a null pointer dereference. You will want to pass the userdata Comments from Reviewable |
44f3b09
to
b573f7b
Compare
b573f7b
to
2929a77
Compare
Review status: 4 of 10 files reviewed at latest revision, 1 unresolved discussion. testing/tox_shell.c, line 59 [r1] (raw file):
|
Reviewed 2 of 9 files at r1, 4 of 4 files at r2. Comments from Reviewable |
Rebase, then I'll merge. |
2929a77
to
1f94c96
Compare
Reviewed 6 of 6 files at r3. Comments from Reviewable |
This change is