Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Friend User Status stateless #57

Merged
merged 1 commit into from
Aug 22, 2016

Conversation

GrayHatter
Copy link

@GrayHatter GrayHatter commented Aug 20, 2016

This change is Reviewable

@GrayHatter
Copy link
Author

Review status: 0 of 6 files reviewed at latest revision, 1 unresolved discussion.


.gitignore, line 69 [r1] (raw file):


# astyle
*.orig

Removed because it breaks git clean and thereby grepping through files.


Comments from Reviewable

@nurupo
Copy link
Member

nurupo commented Aug 21, 2016

:lgtm:

Don't understand the reasoning behind .gitignore though, don't use git clean and have no idea what grepping it breaks.


Reviewed 5 of 6 files at r1.
Review status: 5 of 6 files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@nurupo
Copy link
Member

nurupo commented Aug 21, 2016

Reviewed 1 of 6 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.


Comments from Reviewable

@GrayHatter GrayHatter force-pushed the stateless-user-status branch from af37d34 to 73b24d8 Compare August 22, 2016 09:05
@GrayHatter GrayHatter force-pushed the stateless-user-status branch from 73b24d8 to 3f0c101 Compare August 22, 2016 09:10
@iphydf
Copy link
Member

iphydf commented Aug 22, 2016

:lgtm:


Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@iphydf iphydf merged commit 3f0c101 into TokTok:master Aug 22, 2016
@GrayHatter GrayHatter deleted the stateless-user-status branch August 22, 2016 10:56
@iphydf iphydf modified the milestone: v0.0.1 Nov 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants