Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run fewer Travis jobs during Pull Requests. #690

Merged
merged 1 commit into from
Jan 15, 2018

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jan 15, 2018

Still run all the jobs during cron and regular push to branch. We
disabled build for push to branch, so cron is the only place where all
builds are run. This also means we need to worry less about spending time
in nightly builds, because they occur only once a day.

See travis-ci/travis-ci#9071


This change is Reviewable

@iphydf iphydf added this to the v0.2.0 milestone Jan 15, 2018
@e0ff
Copy link
Member

e0ff commented Jan 15, 2018

:lgtm_strong:


Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@nurupo
Copy link
Member

nurupo commented Jan 15, 2018

It's a sad PR but if the long build times are that much of an issue then alright.

Where can one see the results of cron builds? I'm afraid that a build failure in the cron build might go unnoticed.


Reviewed 2 of 3 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@iphydf
Copy link
Member Author

iphydf commented Jan 15, 2018

The cron builds end up in the build history and on IRC. You're right, it has a higher chance of going unnoticed. I'd say we try it and see if we end up having failures go unnoticed. In the meantime, we speed up development by a factor of about 18.

@nurupo
Copy link
Member

nurupo commented Jan 15, 2018

:lgtm:


Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

Still run all the jobs during cron and regular push to branch. We
disabled build for push to branch, so cron is the only place where all
builds are run. This also means we need to worry less about spending time
in nightly builds, because they occur only once a day.

See travis-ci/travis-ci#9071
@iphydf iphydf closed this Jan 15, 2018
@iphydf iphydf deleted the small-pr-builds branch January 15, 2018 23:41
@iphydf iphydf restored the small-pr-builds branch January 15, 2018 23:41
@iphydf iphydf reopened this Jan 15, 2018
@nurupo
Copy link
Member

nurupo commented Jan 15, 2018

:lgtm_strong:


Reviewed 1 of 2 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@iphydf iphydf merged commit 7110f13 into TokTok:master Jan 15, 2018
@iphydf iphydf deleted the small-pr-builds branch January 15, 2018 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants