Extract named constants from magic numbers in toxav/audio.c.

[iphydf]

By @zoff99.

---

This change is 

[sudden6]

Review status: 0 of 2 files reviewed at latest revision, 6 unresolved discussions.

---

toxav/audio.c, line 137 at r1 (raw file):

    /* Enough space for the maximum frame size (120 ms 48 KHz stereo audio) */
    int16_t temp_audio_buffer[5760 * 2];

use the constant to define this size

---

toxav/audio.h, line 32 at r1 (raw file):

#define AUDIO_JITTERBUFFER_COUNT 3
#define AUDIO_MAX_SAMPLING_RATE 48000

usually it's SAMPLE_RATE

---

toxav/audio.h, line 35 at r1 (raw file):

#define AUDIO_MAX_CHANNEL_COUNT 2

#define AUDIO_START_SAMPLING_RATE 48000

same

---

toxav/audio.h, line 36 at r1 (raw file):

#define AUDIO_START_SAMPLING_RATE 48000
#define AUDIO_START_BITRATE_RATE 48000

BITRATE_RATE seems strange, I recommend BITRATE

---

toxav/audio.h, line 47 at r1 (raw file):

// ((sampling_rate_in_hz * frame_duration_in_ms) / 1000) * 2 // because PCM16 needs 2 bytes for 1 sample
#define AUDIO_MAX_BUFFER_SIZE_PCM16_FOR_FRAME_PER_CHANNEL ((AUDIO_MAX_SAMPLING_RATE * AUDIO_MAX_FRAME_DURATION_MS) / 1000)

rename to AUDIO_MAX_BUFFER_SIZE_PCM16 and add a comment that this is per frame and per channel?

---

toxav/audio.h, line 48 at r1 (raw file):

// ((sampling_rate_in_hz * frame_duration_in_ms) / 1000) * 2 // because PCM16 needs 2 bytes for 1 sample
#define AUDIO_MAX_BUFFER_SIZE_PCM16_FOR_FRAME_PER_CHANNEL ((AUDIO_MAX_SAMPLING_RATE * AUDIO_MAX_FRAME_DURATION_MS) / 1000)
#define AUDIO_MAX_BUFFER_SIZE_BYTES_FOR_FRAME_PER_CHANNEL (AUDIO_MAX_BUFFER_SIZE_PCM16_FOR_FRAME_PER_CHANNEL * 2)

rename to AUDIO_MAX_BUFFER_SIZE_BYTES and add a comment that this is per frame and per channel?

---

Comments from Reviewable

[iphydf]

Review status: 0 of 2 files reviewed at latest revision, 6 unresolved discussions.

---

toxav/audio.c, line 137 at r1 (raw file):

Previously, sudden6 wrote…

use the constant to define this size

Done.

---

toxav/audio.h, line 32 at r1 (raw file):

Previously, sudden6 wrote…

usually it's SAMPLE_RATE

Done.

---

toxav/audio.h, line 35 at r1 (raw file):

Previously, sudden6 wrote…

same

Done.

---

toxav/audio.h, line 36 at r1 (raw file):

Previously, sudden6 wrote…

BITRATE_RATE seems strange, I recommend BITRATE

Done.

---

toxav/audio.h, line 47 at r1 (raw file):

Previously, sudden6 wrote…

rename to AUDIO_MAX_BUFFER_SIZE_PCM16 and add a comment that this is per frame and per channel?

Done.

---

toxav/audio.h, line 48 at r1 (raw file):

Previously, sudden6 wrote…

rename to AUDIO_MAX_BUFFER_SIZE_BYTES and add a comment that this is per frame and per channel?

Done.

---

Comments from Reviewable

[sudden6]

---

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable