Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getters/setters for options. #72

Merged
merged 1 commit into from
Aug 30, 2016
Merged

Add getters/setters for options. #72

merged 1 commit into from
Aug 30, 2016

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Aug 29, 2016

This change is Reviewable

@iphydf iphydf force-pushed the const-abi branch 2 times, most recently from 3e08288 to c97b04e Compare August 29, 2016 22:08
@nurupo
Copy link
Member

nurupo commented Aug 30, 2016

:lgtm:


Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@GrayHatter
Copy link

Has this been tested in any client?

Do any changes made be any of the fxns require the Tox instance to be restarted before they take effect?

Has that been tested in client?


Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@GrayHatter
Copy link

Answered in IRC, I misunderstood the changes.

:lgtm:


Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@GrayHatter
Copy link

Reviewed 3 of 3 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@nurupo
Copy link
Member

nurupo commented Aug 30, 2016

Might as well just make Tox_Options an opaque pointer type.


Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@iphydf iphydf closed this Aug 30, 2016
@iphydf iphydf deleted the const-abi branch August 30, 2016 11:01
@iphydf iphydf merged commit 4692cea into TokTok:master Aug 30, 2016
@iphydf iphydf modified the milestone: v0.0.1 Nov 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants