Use nullptr as NULL pointer constant instead of NULL or 0. #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iphydf
force-pushed
the
nullptr
branch
12 times, most recently
from
e62f09a to
893422f
Compare
|
where does |
|
Correct, it's defined in ccompat.h. The point is that clang 5 has a warning against using 0 as a nullptr constant, which is really nice to have. It got me to fix lots of 0 as null pointer constant in the code. But this warning only exists in C++ mode, so I've defined nullptr as NULL for C mode. |
|
Reviewed 73 of 73 files at r1. Comments from Reviewable |
This changes only code, no string literals or comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes only code, no string literals or comments.
This change is