Add back JOIN/EXIT events for conferences. #795
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoff99
reviewed
Feb 19, 2018
| @@ -2403,6 +2403,22 @@ typedef enum TOX_CONFERENCE_STATE_CHANGE { | |||
| */ | |||
| TOX_CONFERENCE_STATE_CHANGE_PEER_NAME_CHANGE, | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
strange naming?
above in group.h it's "chat" old naming:
CHAT_CHANGE_PEER_NAME
in tox.h now its suddenly "conference":
TOX_CONFERENCE_STATE_CHANGE_PEER_NAME_CHANGE
also the enums are renamed and the values shuffled. why? (this is why enums suck, values get assigned in some magical way)
There was a problem hiding this comment.
I didn't change the name in this PR and I'm not going to change it now, because this whole event will go away later. The enum values are shuffled because this is an incompatible change anyway, and it's easier to remove the ones at the end than at the beginning (removing the beginning would be another ABI breaking change).
iphydf
force-pushed
the
group-join-exit
branch
from
e648d73 to
0a3fe28
Compare
Apparently it's very hard for clients to adapt, so we're keeping the events for now. They are now actively deprecated and should no longer be used. The LIST_CHANGED event is the recommended way, but both events will be emitted.
iphydf
force-pushed
the
group-join-exit
branch
from
0a3fe28 to
d2d99d1
Compare
|
Obsoleted by #799. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently it's very hard for clients to adapt, so we're keeping the
events for now. They are now actively deprecated and should no longer be
used. The LIST_CHANGED event is the recommended way, but both events will
be emitted.
This change is