Add default stderr logger for logging to nullptr. #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iphydf
force-pushed
the
logger-stderr
branch
3 times, most recently
from
d0126d6 to
914b49c
Compare
|
If it should not be used in production code, there should be instructions in the header to not use it in production code. The behavior of logging to stderr in case a nullptr is supplied should also be documented there. Maybe even a |
iphydf
force-pushed
the
logger-stderr
branch
2 times, most recently
from
f9c6936 to
f4a7729
Compare
|
@sudden6 done: added a comment. |
This is useful for debugging a function that doesn't have a logger available. It should not be used in production code, since it outputs to stderr.
|
Reviewed 3 of 3 files at r1. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for debugging a function that doesn't have a logger
available. It should not be used in production code, since it outputs to
stderr.
This change is