Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.2.2 #862

Merged
merged 2 commits into from
Apr 17, 2018
Merged

Release v0.2.2 #862

merged 2 commits into from
Apr 17, 2018

Conversation

robinlinden
Copy link
Member

@robinlinden robinlinden commented Apr 4, 2018

This change is Reviewable

@robinlinden robinlinden added this to the v0.2.2 milestone Apr 4, 2018
@SkyzohKey
Copy link

What about the persistent groupchats PR?

@iphydf
Copy link
Member

iphydf commented Apr 5, 2018

:lgtm_strong:


Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@iphydf
Copy link
Member

iphydf commented Apr 5, 2018

@SkyzohKey it needs tests. There are a few PRs merged in 0.2.2, so we'll release this version now.

@iphydf
Copy link
Member

iphydf commented Apr 5, 2018

@zoff99 @robinlinden do we need #841 in 0.2.2?

@zoff99
Copy link

zoff99 commented Apr 5, 2018

@iphy no

@tox-user
Copy link
Member

tox-user commented Apr 5, 2018

Can we switch groupbot to use persistent groups? That way more people will be able to test it easier. Tens of people use groupbot every day, so we could ask some of them for help with testing.

@sudden6
Copy link

sudden6 commented Apr 15, 2018

blocked by #872

@nurupo
Copy link
Member

nurupo commented Apr 16, 2018

Also blocked by the autotools build being broken in master. You will want to cherry-pick this commit that fixes it before making a release 90202a1. It's part of #867 but I see that that PR might not make it in 0.2.2, so just cherry-pick.

@nurupo
Copy link
Member

nurupo commented Apr 17, 2018

It would also be nice to get #875 in before the release, so that we could see if bootstrap node maintainers update the nodes after we ask them over the mailing list to update. It's not a required PR though, feel free to skip it.

@CLAassistant
Copy link

CLAassistant commented Apr 17, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ robinlinden
❌ nurupo
You have signed the CLA already but the status is still pending? Let us recheck it.

@robinlinden
Copy link
Member Author

The release will be without #867 as I can't merge unsigned commits and I can't push to forks based on irungentoo's Toxcore repository. I've cherry-picked the commit fixing the autotools build. There's still lots of discussion going on in #875 and it shouldn't block the release, so that PR will have to wait too.

@nurupo
Copy link
Member

nurupo commented Apr 17, 2018

:lgtm_strong:


Reviewed 1 of 7 files at r2, 6 of 6 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks pending.


Comments from Reviewable

@robinlinden robinlinden merged commit 2824daf into TokTok:master Apr 17, 2018
@robinlinden robinlinden deleted the 0.2.2 branch August 13, 2018 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

8 participants