Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minitox to under "Other resources" section in the README #877

Merged
merged 1 commit into from
Jun 14, 2018
Merged

Add minitox to under "Other resources" section in the README #877

merged 1 commit into from
Jun 14, 2018

Conversation

hqwrong
Copy link

@hqwrong hqwrong commented Apr 18, 2018 •
edited by iphydf
Loading

see #874

This change is Reviewable

@hqwrong hqwrong mentioned this pull request Apr 18, 2018
Closed
@iphydf iphydf changed the title add minitox ref under [Other resources] section Add minitox to under "Other resources" section in the README Jun 3, 2018
iphydf
iphydf reviewed Jun 3, 2018
View reviewed changes
README.md Outdated
@@ -171,3 +171,5 @@ the API documentation in [toxcore/tox.h](toxcore/tox.h) for more information.
### Other resources

- [Another echo bot](https://wiki.tox.chat/developers/client_examples/echo_bot)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this empty line. Then rebase.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@zoff99
Copy link

zoff99 commented Jun 4, 2018

@iphydf @hqwrong shouldnt minitox be added to the integrations website:
https://github.com/TokTok/website/blob/master/toktok/integrations.md

rather then to the readme in this repo?

@iphydf
Copy link
Member

iphydf commented Jun 4, 2018

It should be added to integrations, yes. I have no strong opinion on whether or not it should be linked in the readme as well.

@tox-user
Copy link
Member

tox-user commented Jun 4, 2018

I think it would be nice if people were able to quickly find a simple example use of toxcore without having to search for it on external websites. Especially since docs seem to be outdated. There was an echobot example somewhere but last time I checked it didn't work (not sure from which repo it was).

@iphydf
Copy link
Member

iphydf commented Jun 14, 2018

:lgtm_strong:

Reviewed 1 of 1 files at r2.
Review status: :shipit: complete! 1 of 1 LGTMs obtained

Comments from Reviewable

@iphydf
Copy link
Member

iphydf commented Jun 14, 2018

Please enable the checkbox "Allow edits from maintainers." on the bottom right.

Also, rebase on current master.

@hqwrong
Copy link
Author

hqwrong commented Jun 14, 2018

strange... I find It's already enabled.

@iphydf
Copy link
Member

iphydf commented Jun 14, 2018

Maybe the problem is that your PR is from master? In the future, try naming your PR branches differently. I'm trying to sign your commit, but github isn't letting me push to your branch.

@iphydf
Copy link
Member

iphydf commented Jun 14, 2018

Problem solved. It was PEBCAK.

@iphydf iphydf merged commit adca701 into TokTok:master Jun 14, 2018
@iphydf iphydf added this to the v0.2.3 milestone Jun 25, 2018
iphydf added a commit to iphydf/c-toxcore that referenced this pull request Sep 5, 2018
@iphydf
Merge tag 'v0.2.3' into ngc_rebase
710f957 
v0.2.3
**Merged PRs:**

- [TokTok#951] Only run astyle if the astyle binary exists.
- [TokTok#950] Remove utils.c and utils.h from toxencryptsave build.
- [TokTok#949] Fixes to the imported sodium sources to compile without warnings.
- [TokTok#948] Add a MAX_HOSTNAME_LENGTH constant.
- [TokTok#947] Remove the format test.
- [TokTok#937] Add new Circle CI configuration.
- [TokTok#935] Add a test for double conference invite.
- [TokTok#933] Add Logger to various net_crypto functions, and add `const` to Logger where possible.
- [TokTok#931] Avoid conditional-uninitialised warning for tcp test.
- [TokTok#930] Disable UDP when proxy is enabled.
- [TokTok#928] Use clang-format for C++ code.
- [TokTok#927] Add assertions to bootstrap tests for correct connection type.
- [TokTok#926] Make NULL options behave the same as default options.
- [TokTok#925] Add tests for what happens when passing an invalid proxy host.
- [TokTok#924] Make the net_crypto connection state an enum.
- [TokTok#922] Clarify/Improve test_some test
- [TokTok#921] Beginnings of a TCP_test.c overhaul
- [TokTok#920] Add test for creating multiple conferences in one tox.
- [TokTok#918] Merge irungentoo/master into toktok
- [TokTok#917] Add random testing program.
- [TokTok#916] Fix linking with address sanitizer.
- [TokTok#915] Remove resource_leak_test.
- [TokTok#914] Make dht_test more stable.
- [TokTok#913] Minor cleanup: return early on error condition.
- [TokTok#906] Sort bazel build file according to buildifier standard.
- [TokTok#905] In DEBUG mode, make toxcore crash on signed integer overflow.
- [TokTok#902] Log only the filename, not the full path in LOGGER.
- [TokTok#899] Fix macOS macro because of GNU Mach
- [TokTok#898] Fix enumeration of Crypto_Connection instances
- [TokTok#897] Fix ipport_isset: port 0 is not a valid port.
- [TokTok#894] Fix logging related crash in bootstrap node
- [TokTok#893] Fix bootstrap crashes, still
- [TokTok#892] Add empty logger to DHT bootstrap daemons.
- [TokTok#887] Fix FreeBSD build on Travis
- [TokTok#884] Fix the often call of event tox_friend_connection_status
- [TokTok#883] Make toxcore compile on BSD
- [TokTok#878] fix DHT_bootstrap key loading
- [TokTok#877] Add minitox to under "Other resources" section in the README
- [TokTok#875] Make bootstrap daemon use toxcore's version
- [TokTok#867] Improve network error reporting on Windows
- [TokTok#841] Only check full rtp offset if RTP_LARGE_FRAME is set
- [TokTok#823] Finish @Diadlo's network Family abstraction.
- [TokTok#822] Move system header includes from network.h to network.c
iphydf added a commit to iphydf/c-toxcore that referenced this pull request Sep 5, 2018
@iphydf
Merge tag 'v0.2.3' into ngc_rebase
5aa5604 
v0.2.3
**Merged PRs:**

- [TokTok#951] Only run astyle if the astyle binary exists.
- [TokTok#950] Remove utils.c and utils.h from toxencryptsave build.
- [TokTok#949] Fixes to the imported sodium sources to compile without warnings.
- [TokTok#948] Add a MAX_HOSTNAME_LENGTH constant.
- [TokTok#947] Remove the format test.
- [TokTok#937] Add new Circle CI configuration.
- [TokTok#935] Add a test for double conference invite.
- [TokTok#933] Add Logger to various net_crypto functions, and add `const` to Logger where possible.
- [TokTok#931] Avoid conditional-uninitialised warning for tcp test.
- [TokTok#930] Disable UDP when proxy is enabled.
- [TokTok#928] Use clang-format for C++ code.
- [TokTok#927] Add assertions to bootstrap tests for correct connection type.
- [TokTok#926] Make NULL options behave the same as default options.
- [TokTok#925] Add tests for what happens when passing an invalid proxy host.
- [TokTok#924] Make the net_crypto connection state an enum.
- [TokTok#922] Clarify/Improve test_some test
- [TokTok#921] Beginnings of a TCP_test.c overhaul
- [TokTok#920] Add test for creating multiple conferences in one tox.
- [TokTok#918] Merge irungentoo/master into toktok
- [TokTok#917] Add random testing program.
- [TokTok#916] Fix linking with address sanitizer.
- [TokTok#915] Remove resource_leak_test.
- [TokTok#914] Make dht_test more stable.
- [TokTok#913] Minor cleanup: return early on error condition.
- [TokTok#906] Sort bazel build file according to buildifier standard.
- [TokTok#905] In DEBUG mode, make toxcore crash on signed integer overflow.
- [TokTok#902] Log only the filename, not the full path in LOGGER.
- [TokTok#899] Fix macOS macro because of GNU Mach
- [TokTok#898] Fix enumeration of Crypto_Connection instances
- [TokTok#897] Fix ipport_isset: port 0 is not a valid port.
- [TokTok#894] Fix logging related crash in bootstrap node
- [TokTok#893] Fix bootstrap crashes, still
- [TokTok#892] Add empty logger to DHT bootstrap daemons.
- [TokTok#887] Fix FreeBSD build on Travis
- [TokTok#884] Fix the often call of event tox_friend_connection_status
- [TokTok#883] Make toxcore compile on BSD
- [TokTok#878] fix DHT_bootstrap key loading
- [TokTok#877] Add minitox to under "Other resources" section in the README
- [TokTok#875] Make bootstrap daemon use toxcore's version
- [TokTok#867] Improve network error reporting on Windows
- [TokTok#841] Only check full rtp offset if RTP_LARGE_FRAME is set
- [TokTok#823] Finish @Diadlo's network Family abstraction.
- [TokTok#822] Move system header includes from network.h to network.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iphydf iphydf iphydf left review comments

Assignees
No one assigned
Labels
None yet
Milestone
v0.2.3
Development

Successfully merging this pull request may close these issues.
4 participants
@hqwrong @zoff99 @iphydf @tox-user