-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Travis-CI FreeBSD build #986
Conversation
|
2ee0891
to
d381770
Compare
d467d85
to
9662a98
Compare
Here is the build https://travis-ci.org/TokTok/c-toxcore/builds/402243877. |
9662a98
to
fe9ba95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 LGTMs obtained (waiting on @iphydf)
.travis/cmake-freebsd-stage2, line 18 at r1 (raw file):
# Extract the cached image tar -Sxzvf $IMAGE_NAME.tgz
Put variables into double quotes to avoid potential double parsing of values with spaces in them.
c433447
to
2a57664
Compare
Hm, the build suddenly started failing, it wasn't doing that before. |
Sending |
5c47858
to
3c116f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 9 files at r1, 4 of 4 files at r2.
Reviewable status: 0 of 1 LGTMs obtained
.travis/cmake-freebsd-stage2, line 18 at r1 (raw file):
Previously, iphydf wrote…
Put variables into double quotes to avoid potential double parsing of values with spaces in them.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 LGTMs obtained
.travis/cmake-freebsd-stage1, line 0 at r2 (raw file):
File appears to be binary.
Good job reviewable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 LGTMs obtained
.travis/cmake-freebsd-stage1, line at r2 (raw file):
Previously, nurupo wrote…
File appears to be binary.
Good job reviewable.
It's because there is a literal ESC byte in this script instead of an escape sequence for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! 1 of 1 LGTMs obtained
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! 1 of 1 LGTMs obtained
.travis/cmake-freebsd-stage1, line at r2 (raw file):
Previously, iphydf wrote…
It's because there is a literal ESC byte in this script instead of an escape sequence for it.
That was my guess.
3c116f9
to
c0b4cd1
Compare
Rebased on master. |
I went ahead and updated FreeBSD to use 11.2 image because the 11.1 was giving
message. I had to reduce the 8 mirrors down to 2, because apparently only 2 of them have 11.2 release. They must be syncing once per month or rarer. We could add more mirrors as more of them get the release.
This change is