Move load_state and its helper functions to their own module.

[iphydf]

This change is 

[sudden6]

Reviewed 8 of 10 files at r1.
Reviewable status: 0 of 1 LGTMs obtained

---

toxcore/state.h, line 9 at r1 (raw file):

extern "C" {
#endif

Can you add a comment what the purpose of this module is?

---

toxcore/state.c, line 63 at r1 (raw file):

}

uint16_t lendian_to_host16(uint16_t lendian)

why re-implement functionality we already have in net_pack_*? I'd prefer to do this architecture dependent serialization at exactly one place.

[iphydf]

Reviewable status: 0 of 1 LGTMs obtained

---

toxcore/state.c, line 63 at r1 (raw file):

Previously, sudden6 wrote…

why re-implement functionality we already have in net_pack_*? I'd prefer to do this architecture dependent serialization at exactly one place.

Note that I moved these functions from util.c, I didn't reimplement anything here. Also note that these functions convert to little endian, since the save data format has a mix of big and little endian (and maybe some machine dependent ones that are de-facto little endian.

I don't want these in network.h because they have nothing to do with sending things over the network, but everything to do with writing state to a byte array.

Also note that these functions are not inherently architecture dependent. Their current implementation is, as an optimisation, because clearly toxcore was designed to write gigabytes of save data per second :) (more seriously: I'm going to rewrite these in a portable way).

[sudden6]

---

toxcore/state.c, line 63 at r1 (raw file):

Previously, iphydf wrote…

Note that I moved these functions from util.c, I didn't reimplement anything here. Also note that these functions convert to little endian, since the save data format has a mix of big and little endian (and maybe some machine dependent ones that are de-facto little endian.

I don't want these in network.h because they have nothing to do with sending things over the network, but everything to do with writing state to a byte array.

Also note that these functions are not inherently architecture dependent. Their current implementation is, as an optimisation, because clearly toxcore was designed to write gigabytes of save data per second :) (more seriously: I'm going to rewrite these in a portable way).

Maybe we should then create a pack module that does exactly this byte packing for saving and network? Maybe not now. IMO we should at least leave a comment to unify this.

[iphydf]

Reviewable status: 0 of 1 LGTMs obtained

---

toxcore/state.h, line 9 at r1 (raw file):

Previously, sudden6 wrote…

Can you add a comment what the purpose of this module is?

Done.

---

toxcore/state.c, line 63 at r1 (raw file):

Previously, sudden6 wrote…

Maybe we should then create a pack module that does exactly this byte packing for saving and network? Maybe not now. IMO we should at least leave a comment to unify this.

I think it's good to have state_pack_* functions here (renaming the lendian functions here) and net_pack_* in the network module.

[sudden6]

Reviewed 1 of 10 files at r1, 1 of 1 files at r2.
Reviewable status: 0 of 1 LGTMs obtained

---

toxcore/state.c, line 63 at r1 (raw file):

Previously, iphydf wrote…

I think it's good to have state_pack_* functions here (renaming the lendian functions here) and net_pack_* in the network module.

ok, I can live with that for now.