Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add more functions to the unsafe list with explanations. #110

Merged
merged 1 commit into from
Jan 15, 2022

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Jan 14, 2022

It will look like:

c-toxcore/toxcore/Messenger.c:2478: function `sprintf' should not be used, because it has no way of bounding the number of characters written; use snprintf instead

This change is Reviewable

@iphydf iphydf added this to the v0.0.9 milestone Jan 14, 2022
@auto-add-label auto-add-label bot added the enhancement New feature for the user, not a new feature for build script label Jan 14, 2022
Copy link
Member

@JFreegman JFreegman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

It will look like:
```
c-toxcore/toxcore/Messenger.c:2478: function `sprintf' should not be used, because it has no way of bounding the number of characters written; use snprintf instead
```
@iphydf iphydf force-pushed the more-unsafe-funcs branch from 4954889 to 37ce1d0 Compare January 14, 2022 23:44
@iphydf iphydf merged commit 37ce1d0 into TokTok:master Jan 15, 2022
@iphydf iphydf deleted the more-unsafe-funcs branch January 15, 2022 00:50
@iphydf iphydf temporarily deployed to tokstyle January 15, 2022 00:50 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature for the user, not a new feature for build script
Development

Successfully merging this pull request may close these issues.

2 participants