Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive Trust Graph #4488

Merged
merged 4 commits into from
May 15, 2019
Merged

Conversation

xoriole
Copy link
Contributor

@xoriole xoriole commented May 9, 2019

This PR includes the Trust Graph with basic interaction like node selection and dragging the graph at root node. The details of the selected node is also shown at the bottom of the graph. Here is a screenshot showing how it looks.

trust_graph_interactive

@xoriole xoriole force-pushed the interactive-trust-graph branch from e7a96dc to 0e4a946 Compare May 9, 2019 14:41
@MaxVanDeursen
Copy link

Dear @xoriole, I just noticed this PR and it seems to be like you're doing a continuation/rework on a project of a project of mine and a few fellow students, which can be found in #2958. Maybe you can take some inspiration from this PR, or even adjust the code to work with the current version of the Tribler codebase.

A live demo can be found here.

@synctext
Copy link
Member

Hey @MaxVanDeursen,
Yes, this is based on all the prior trust work that has been done. Key point of improvement is that this is hand-crafted QT for real-time animation. We removed the javascript dependency and installer size increase.

@MaxVanDeursen
Copy link

@synctext Sounds good! I'll keep an eye on this PR!

@xoriole xoriole force-pushed the interactive-trust-graph branch from 0e4a946 to 1134279 Compare May 14, 2019 12:55
@xoriole
Copy link
Contributor Author

xoriole commented May 14, 2019

Dear @MaxVanDeursen, I have seen your work on #2905. That is beautiful and a lot more interactive compared to this one but we wanted to have something operational with limited Qt dependencies. One of the downsides here is that the extensive CPU usage in rendering. Hopefully, it will get better with the next iteration.

@xoriole xoriole marked this pull request as ready for review May 15, 2019 08:43
@xoriole xoriole changed the title Interactive Trust Graph READY: Interactive Trust Graph May 15, 2019
@@ -231,5 +342,12 @@ def update_gui_labels(self, data):
else:
self.window().trust_graph_progress_bar.setHidden(False)
self.window().trust_graph_progress_bar.setValue(bootstrap_progress)
status_message = "Transactions: %s | Peers: %s" % (data['num_tx'], len(data['positions']))

status_message = u"<strong style='font-size:14px'>Transactions : %s &nbsp;&nbsp; " \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why &nbsp; here and SPACE in the other locations?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistency! Resolved

@xoriole xoriole force-pushed the interactive-trust-graph branch from 5033667 to b980da7 Compare May 15, 2019 10:25
@ichorid
Copy link
Contributor

ichorid commented May 15, 2019

Maybe you could try to use http://www.pyqtgraph.org/ to make it more efficient?

@xoriole
Copy link
Contributor Author

xoriole commented May 15, 2019

@ichorid Yes, it seems like an efficient alternative. As long as we can ship it nicely in all platforms, we can use it. I'll check it out. Thanks

Copy link
Contributor

@qstokkink qstokkink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to merge this now, or try the other package first?

@xoriole
Copy link
Contributor Author

xoriole commented May 15, 2019

It is working fine so I would say lets merge it for now and pyqtgraph, if can be used with packaging issue resolved, can come in a separate PR.

@qstokkink qstokkink changed the title READY: Interactive Trust Graph Interactive Trust Graph May 15, 2019
@qstokkink qstokkink merged commit ccc6efa into Tribler:devel May 15, 2019
@xoriole xoriole deleted the interactive-trust-graph branch August 4, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants