-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interactive Trust Graph #4488
Interactive Trust Graph #4488
Conversation
e7a96dc
to
0e4a946
Compare
Dear @xoriole, I just noticed this PR and it seems to be like you're doing a continuation/rework on a project of a project of mine and a few fellow students, which can be found in #2958. Maybe you can take some inspiration from this PR, or even adjust the code to work with the current version of the Tribler codebase. A live demo can be found here. |
Hey @MaxVanDeursen, |
@synctext Sounds good! I'll keep an eye on this PR! |
0e4a946
to
1134279
Compare
Dear @MaxVanDeursen, I have seen your work on #2905. That is beautiful and a lot more interactive compared to this one but we wanted to have something operational with limited Qt dependencies. One of the downsides here is that the extensive CPU usage in rendering. Hopefully, it will get better with the next iteration. |
TriblerGUI/widgets/trustgraphpage.py
Outdated
@@ -231,5 +342,12 @@ def update_gui_labels(self, data): | |||
else: | |||
self.window().trust_graph_progress_bar.setHidden(False) | |||
self.window().trust_graph_progress_bar.setValue(bootstrap_progress) | |||
status_message = "Transactions: %s | Peers: %s" % (data['num_tx'], len(data['positions'])) | |||
|
|||
status_message = u"<strong style='font-size:14px'>Transactions : %s " \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why
here and SPACE
in the other locations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistency! Resolved
5033667
to
b980da7
Compare
Maybe you could try to use http://www.pyqtgraph.org/ to make it more efficient? |
@ichorid Yes, it seems like an efficient alternative. As long as we can ship it nicely in all platforms, we can use it. I'll check it out. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to merge this now, or try the other package first?
It is working fine so I would say lets merge it for now and |
This PR includes the Trust Graph with basic interaction like node selection and dragging the graph at root node. The details of the selected node is also shown at the bottom of the graph. Here is a screenshot showing how it looks.