Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qr code with halfblock struct #129

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Robert-ML
Copy link

We do not have access to create new branches and this PR is to have a linkage in the original ap to our work so far

@InvictusRMC InvictusRMC marked this pull request as draft February 27, 2023 11:49
@InvictusRMC InvictusRMC changed the title [DO NOT MERGE] qr code with halfblock struct qr code with halfblock struct Feb 27, 2023
@InvictusRMC
Copy link
Member

I converted the PR to a draft. FYI you can run ./gradlew check locally to run the build and test task (much faster than this runner)

@OrestisKan
Copy link
Collaborator

OrestisKan commented Mar 6, 2023

This is using features of Gradle that are not supported in Gradle 8.0 so the APK cannot be released if this is merged
Also this exception is thrown: com.android.ide.common.signing.KeytoolException: Failed to read key from store "/home/runner/work/trustchain-superapp/trustchain-superapp/app/build.keystore

@InvictusRMC
Copy link
Member

InvictusRMC commented Mar 6, 2023

@OrestisKan can you rebase our main branch onto your fork? Then the CI should work.

@OrestisKan
Copy link
Collaborator

This one? Robert-ML:OTM7296_dev

@Robert-ML Robert-ML temporarily deployed to apk_build March 6, 2023 14:18 — with GitHub Actions Inactive
@InvictusRMC
Copy link
Member

It works now; great! You now have a signed APK you can test: https://github.com/Tribler/trustchain-superapp/suites/11376632385/artifacts/585353425

@OrestisKan
Copy link
Collaborator

Ok I managed to finally compile it and also flash the apk on my Samsung. The qr seems fine to me and it looks like its working.

@Robert-ML
Copy link
Author

Great. We will push an update this week with more functionalities hopefully by friday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants