Update all deps to current #245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The time-consuming part of reviewing this will be reviewing the changes in dependencies. It may work fine in passing, but it's easy for breaking changes to hide in code paths not tested by casual use (or even the unit tests). That's not to say we need to go over every change in every dependency, but I wouldn't be comfortable merging this without at least checking each project's changelog (where they have them) and (additionally) trying to identify the changes resulting in major version bumps. |
|
Since this now has conflicts I'm going to replace it with with a PR using a separate branch on my side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't gone through all the deps for breaking changes but I've been using it for a few days with no problems.