Finished and edited Slovak locale #21800
Conversation
|
Hi @pipozzz , @timemanagementsk , @FungY911 , if you have time to review this new Slovak contribution, I'd appreciate it! :) |
|
I'll check that later today |
Co-authored-by: Peter Gonda <[email protected]>
Co-authored-by: Peter Gonda <[email protected]>
Co-authored-by: Peter Gonda <[email protected]>
Co-authored-by: Peter Gonda <[email protected]>
Co-authored-by: Peter Gonda <[email protected]>
Co-authored-by: Peter Gonda <[email protected]>
Co-authored-by: Peter Gonda <[email protected]>
Co-authored-by: Peter Gonda <[email protected]>
Co-authored-by: Peter Gonda <[email protected]>
Thank you for the correction, I tried my best but my dyslexia was stronger. Thank´s again 👍 |
There was a problem hiding this comment.
Thank you for this contribution! I've marked a few spots that look like they might be errors. This is an AI-based review (with a non-Slovak speaker inspecting the output and deciding which things might be actionable), so you are welcome to reject any of my comments, as your Slovak is much better than mine! :)
btw, what AI - review stuff do you use? |
A mix of ChatGPT-4o and Deepl, along with some human filtering of the output. I mostly ignore it when it says "blah blah might sound better" (because I trust the human translator there), but I'm looking for spelling errors, attempts to deface, mistranslations, copy-paste errors, and it does seem to identify those fairly well. It's not perfect, but for languages where we might not have a trusted native speaker who can review a submission, it stops your submission from being blocked until a trusted native speaker is available. And sometimes I find typos that a human reviewer has missed, so there's that. |
Co-authored-by: Cathy Sarisky <[email protected]>
ghost/i18n/locales/sk/portal.json
Outdated
| "Something went wrong, please try again later.": "", | ||
| "Sorry, no recommendations are available right now.": "", | ||
| "Something went wrong, please try again later.": "Niečo sa pokazilo, skúste to prosím neskôr.", | ||
| "Sorry, no recommendations are available right now.": "Prepáčte, moemntálne nie sú dosptupné žiadne odporúčania.", |
There was a problem hiding this comment.
These spelling errors still need to be corrected, thanks!
| @@ -167,6 +167,7 @@ | |||
| "There was an error sending the email, please try again": "Pri odosielaní e-mailu došlo k chybe, skúste to prosím znova", | |||
| "This site is invite-only, contact the owner for access.": "Táto stránka je iba pre pozvaných úžívateľov, kontaktujte vlastníka stránky.", | |||
| "This site is not accepting payments at the moment.": "Táto stránka momentálne neprijíma platby.", | |||
| "This site only accepts paid members.": "", | |||
There was a problem hiding this comment.
If you can add this translation also, that'd be great.
|
Hey @Techkrypt-xyz , I think we are very close here - if you can fix the spelling errors, I can put this in the queue to be merged! (You marked a couple comments about spelling errors as resolved or agreed they were errors, but maybe you didn't push the changes that fix them? I can't do that for you.) |
|
@coderabbitai , would you please review this submission? |
|
@cathysarisky I've reviewed the Slovak translations and found them to be of high quality overall. However, there are a few minor issues that should be addressed:
The rest of the translations appear to be complete, grammatically correct, and contextually appropriate. Would you like me to create an issue to track these remaining items? 🔗 Analysis chain🏁 Scripts executedThe following scripts were executed for the analysis: Script: Length of output: 25 Script: Length of output: 584 Script: Length of output: 16836 Script: Length of output: 465 Script: Length of output: 45704 ✅ Actions performedReview triggered.
|
WalkthroughThe pull request updates the Slovak language localization across several files. In Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Hey @Techkrypt-xyz , one more nudge - I think there's five minutes of work for this to be ready to merge. See comment about spelling mistakes. |
Co-authored-by: Cathy Sarisky <[email protected]>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🔭 Outside diff range comments (1)
ghost/i18n/locales/sk/portal.json (1)
209-211:⚠️ Potential issueCorrecting “Your subscription” Phrases
On lines 209–211, the translations start with “Váše predplatné …”. The correct spelling should be “Vaše” (without the accent on the “a”). Please update all occurrences accordingly.
A combined diff could be:- "Your subscription will expire on {{expiryDate}}": "Váše predplatné expiruje {{expiryDate}}", - "Your subscription will renew on {{renewalDate}}": "Váše predplatné bude obnovené {{renewalDate}}", - "Your subscription will start on {{subscriptionStart}}": "Váše predplatné začína {{subscriptionStart}}" + "Your subscription will expire on {{expiryDate}}": "Vaše predplatné expiruje {{expiryDate}}", + "Your subscription will renew on {{renewalDate}}": "Vaše predplatné bude obnovené {{renewalDate}}", + "Your subscription will start on {{subscriptionStart}}": "Vaše predplatné začína {{subscriptionStart}}"
♻️ Duplicate comments (2)
ghost/i18n/locales/sk/newsletter.json (1)
2-23:⚠️ Potential issueGrammar Correction in Trial Cancellation Message
On line 19, the translation reads:
"Your free trial ends on {date}, at which time you will be charged the regular price. You can always cancel before then." : "Vaše bezplatné skúšobné obdobie skončí {date} a v tom čase vám bude účtovaný poplatok za predplatné. Môžete to pred tým zrušiť."
For correct Slovak grammar, please change “pred tým” to “predtým”.
A suggested diff is:-"Môžete to pred tým zrušiť." +"Môžete to predtým zrušiť."ghost/i18n/locales/sk/portal.json (1)
18-18:⚠️ Potential issueSpelling and Grammar Corrections in Free Trial Message
On line 18, the translation"After a free trial ends, you will be charged the regular price for the tier you've chosen. You can always cancel before then." : "Po uplynutí skúšobného obdobia vám bute účtovaná bežná cena pre vybrunú úrovenň. Vždy to môžte pred tým zrušiť"contains several typos:
- “bute” should be “bude”
- “vybrunú úrovenň” should be “vybranú úrovň”
- “pred tým” should be “predtým”
A suggested diff:-"Po uplynutí skúšobného obdobia vám bute účtovaná bežná cena pre vybrunú úrovenň. Vždy to môžte pred tým zrušiť" +"Po uplynutí skúšobného obdobia vám bude účtovaná bežná cena za vybranú úrovň. Vždy to môžete predtým zrušiť"
🧹 Nitpick comments (2)
ghost/i18n/locales/sk/comments.json (1)
9-9: Minor Spacing Issue in Context Message
On line 9, the translation string
"Pridajte kontext do vášho komentára, zdielajte svoje meno, a odbornosť pre podporu zdravej diskusie."
contains an extra space between “svoje” and “meno”. Please remove the additional space.
A possible fix:-"zdielajte svoje meno" +"zdielajte svoje meno"ghost/i18n/locales/sk/portal.json (1)
192-192: Greeting Correction
On line 192, the translation for "Welcome back, {{name}}!" is given as:
"Vitaje späť, {{name}}!"
Please change “Vitaje” to “Vitajte” for the correct imperative form.
Diff suggestion:-"Vitaje späť, {{name}}!" +"Vitajte späť, {{name}}!"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
ghost/i18n/locales/sk/comments.json(2 hunks)ghost/i18n/locales/sk/ghost.json(1 hunks)ghost/i18n/locales/sk/newsletter.json(1 hunks)ghost/i18n/locales/sk/portal.json(5 hunks)
🧰 Additional context used
🧠 Learnings (1)
ghost/i18n/locales/sk/newsletter.json (1)
Learnt from: cathysarisky
PR: TryGhost/Ghost#22007
File: ghost/i18n/locales/sl/newsletter.json:18-18
Timestamp: 2025-01-28T13:58:08.393Z
Learning: When reviewing translations of newsletter.json, check that the translations of status words (free/complimentary/paid/trialing) will form grammatically correct sentences when substituted into the message template. The status words should agree grammatically with the word "subscriber" in the target language.
🪛 Biome (1.9.4)
ghost/i18n/locales/sk/portal.json
[error] 109-109: Invalid escape sequence
Valid escape sequences are: \\, \/, /", \b\, \f, \n, \r, \t or any unicode escape sequence \uXXXX where X is hexedecimal number.
(parse)
ghost/i18n/locales/sk/comments.json
[error] 59-59: The key Show {{amount}} more replies was already declared.
This where a duplicated key was declared again.
If a key is defined multiple times, only the last definition takes effect. Previous definitions are ignored.
(lint/suspicious/noDuplicateObjectKeys)
🔇 Additional comments (5)
ghost/i18n/locales/sk/newsletter.json (1)
1-1: Overall Newsletter Translations – Looks Good
The rest of the key–value pairs appear to be properly localized.ghost/i18n/locales/sk/ghost.json (1)
19-19: Update “Sign in” Translation
The change from"Sign in": "Prihlásiť"to"Sign in": "Prihlásiť sa"correctly incorporates the reflexive pronoun for better clarity.ghost/i18n/locales/sk/comments.json (1)
1-73: Overall Comments Localization Review
All other translations in this file appear appropriate and consistent with previous reviews and localization guidelines.🧰 Tools
🪛 Biome (1.9.4)
[error] 59-59: The key Show {{amount}} more replies was already declared.
This where a duplicated key was declared again.
If a key is defined multiple times, only the last definition takes effect. Previous definitions are ignored.
(lint/suspicious/noDuplicateObjectKeys)
ghost/i18n/locales/sk/portal.json (2)
109-109: Static Analysis: Invalid Escape Sequence Warning
Static analysis reported an invalid escape sequence at line 109. Although the string at that location"More like this": "Viac podobných",does not obviously include problematic escape characters, please verify that all escape sequences in this file conform to JSON standards (e.g., using
\\for backslashes).🧰 Tools
🪛 Biome (1.9.4)
[error] 109-109: Invalid escape sequence
Valid escape sequences are:
\\,\/,/",\b\,\f,\n,\r,\tor any unicode escape sequence\uXXXXwhere X is hexedecimal number.(parse)
1-213: Overall Portal Localization Review
The remaining translations in the portal file are largely complete and improve the overall user interface for Slovak-speaking users. Please review the minor issues noted above so that all texts are both grammatically correct and consistent.🧰 Tools
🪛 Biome (1.9.4)
[error] 109-109: Invalid escape sequence
Valid escape sequences are:
\\,\/,/",\b\,\f,\n,\r,\tor any unicode escape sequence\uXXXXwhere X is hexedecimal number.(parse)
ghost/i18n/locales/sk/comments.json
Outdated
| "Show {{amount}} more replies": "Zobraziť {{amount}} ďalších odpovedí", | ||
| "Show {{amount}} previous comments": "Zobraziť {{amount}} predchádzajúcich komentárov", | ||
| "Show {{amount}} more replies": "Zobraziť {{amount}} ďalších odpoveďí", |
There was a problem hiding this comment.
Duplicate Key Notice: "Show {{amount}} more replies"
The key "Show {{amount}} more replies" is declared twice (line 58 and line 60) with identical values. In JSON, duplicate keys can lead to unexpected behavior as only the last occurrence is effective. Please remove or consolidate the duplicate entry.
A suggested diff is:
- "Show {{amount}} more replies": "Zobraziť {{amount}} ďalších odpovedí",(ensure that only one instance remains)
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "Show {{amount}} more replies": "Zobraziť {{amount}} ďalších odpovedí", | |
| "Show {{amount}} previous comments": "Zobraziť {{amount}} predchádzajúcich komentárov", | |
| "Show {{amount}} more replies": "Zobraziť {{amount}} ďalších odpoveďí", | |
| "Show {{amount}} previous comments": "Zobraziť {{amount}} predchádzajúcich komentárov", | |
| "Show {{amount}} more replies": "Zobraziť {{amount}} ďalších odpovědí", |
🧰 Tools
🪛 Biome (1.9.4)
[error] 59-59: The key Show {{amount}} more replies was already declared.
This where a duplicated key was declared again.
If a key is defined multiple times, only the last definition takes effect. Previous definitions are ignored.
(lint/suspicious/noDuplicateObjectKeys)
| "Email newsletter settings updated": "", | ||
| "Email": "E-mail", | ||
| "Email newsletter": "E-mail newsletteru", | ||
| "Email newsletter settings updated": "Nastavenia e-mailu newslettera aktualizované", | ||
| "Email preferences": "E-mailové nastavnia", |
There was a problem hiding this comment.
Correction in “Email preferences”
On line 61, the key-value pair is:
"Email preferences": "E-mailové nastavnia",
There is a spelling mistake in the translation value. It should be:
"E-mailové nastavenia"
A diff suggestion:
-"E-mailové nastavnia"
+"E-mailové nastavenia"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "Email preferences": "E-mailové nastavnia", | |
| "Email preferences": "E-mailové nastavenia", |
| "There was an error cancelling your subscription, please try again.": "Pri zrušení vášho predplatného došlo k chybe, skúste to prosím znova.", | ||
| "There was an error continuing your subscription, please try again.": "Pri predĺžení vášho predplatného sa vyskytla chyba, prosím skúste to znovu", | ||
| "There was an error processing your payment. Please try again.": "Pri spracovaní vašej platby došlo k chybe. Skúste to prosím znova.", | ||
| "There was an error sending the email, please try again": "Pri odosielaní e-mailu došlo k chybe, skúste to prosím znova", | ||
| "This site is invite-only, contact the owner for access.": "Táto stránka je iba pre pozvaných úžívateľov, kontaktujte vlastníka stránky.", |
There was a problem hiding this comment.
Typo in “invite-only” Message
On line 168, the phrase:
"Táto stránka je iba pre pozvaných úžívateľov, kontaktujte vlastníka stránky."
features a spelling error. “úžívateľov” should be corrected to “užívateľov”.
A suggested diff:
-"úžívateľov"
+"užívateľov"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "This site is invite-only, contact the owner for access.": "Táto stránka je iba pre pozvaných úžívateľov, kontaktujte vlastníka stránky.", | |
| "This site is invite-only, contact the owner for access.": "Táto stránka je iba pre pozvaných užívateľov, kontaktujte vlastníka stránky.", |
I have completed the translation of the Slovak language for the missing phrases and edited some of them for grammatical correctness, word order and context.