[TT-13508] Streams poor performance when reconnecting to a Streams API #6697

buraksezer · 2024-11-08T08:39:55Z

User description

PR for https://tyktech.atlassian.net/browse/TT-13508

Changes:

Bento updated to this commit: warpstreamlabs/bento@755c497
removeStream uses the correct key to remove an inactive stream, not combining it with the API ID.

Related PR: warpstreamlabs/bento#125

PR Type

Bug fix, Enhancement

Description

Fixed a bug in the removeStream function by using the correct key for removing inactive streams, ensuring that the API ID is not combined with the stream ID.
Updated the google.golang.org/grpc dependency to version v1.67.0.
Updated the github.com/warpstreamlabs/bento dependency to a specific commit for improved performance.
Updated several other dependencies to their latest versions to ensure compatibility and leverage new features.

Changes walkthrough 📝

Relevant files

Bug fix

manager.go Correct stream removal logic in `removeStream` function ee/middleware/streams/manager.go Fixed the `removeStream` function to use the correct key for stream removal. Removed the combination of API ID with stream ID for stream identification.	+2/-4

Dependencies

go.mod `Update dependencies to latest versions` go.mod Updated `google.golang.org/grpc` to version `v1.67.0`. Updated `github.com/warpstreamlabs/bento` to a specific commit. Updated various dependencies to newer versions.	+65/-45

Additional files (token-limit)

go.sum `...` go.sum ...	+1054/-103

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

…e stream

buger · 2024-11-08T08:40:12Z

💔 The detected issue is not in one of the allowed statuses 💔

Detected Status	Open	❌
Allowed Statuses	In Dev,In Code Review,Ready for Testing,In Test,In Progress,In Review	✔️

Please ensure your jira story is in one of the allowed statuses

github-actions · 2024-11-08T08:40:46Z

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review Refactoring The changes in the `removeStream` function simplify the stream ID handling by directly using `streamID` instead of constructing a `streamFullID`. This should be carefully tested to ensure that it does not affect the functionality where multiple APIs might share the same `streamID` but differ in `APIID`.

github-actions · 2024-11-08T08:41:00Z

PR Code Suggestions ✨

No code suggestions found for the PR.

github-actions · 2024-11-08T08:41:23Z

API Changes

no api changes detected

sonarqubecloud · 2024-11-08T09:59:48Z

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

…ick some changes from latest main branch. (#6700) ### **User description** Bento >=1.3.0 requires an OpenTelemetry upgrade and it breaks our E2E tests. Here is some details: https://tyktech.atlassian.net/browse/TT-13518 This PR downgrades Bento to v1.2.0 and cherry-picks some changes from the main branch to fix TT-13508. See this #6697 ___ ### **PR Type** enhancement, dependencies ___ ### **Description** - Downgraded `google.golang.org/grpc` from v1.67.0 to v1.66.2 to address compatibility issues. - Downgraded `github.com/warpstreamlabs/bento` from v1.3.1 to v1.2.0 and replaced it with a forked version from `github.com/TykTechnologies/bento`. - Downgraded `go.opentelemetry.io/otel` and related packages from v1.29.0 to v1.24.0 to resolve issues with OpenTelemetry upgrades. - Updated multiple indirect dependencies to earlier versions to maintain compatibility and stability. ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Dependencies</strong></td><td><table> <tr> <td> <details> <summary><strong>go.mod</strong><dd><code>Downgrade dependencies and switch to a forked Bento version</code></dd></summary> <hr> go.mod <li>Downgraded <code>google.golang.org/grpc</code> from v1.67.0 to v1.66.2.<br> <li> Downgraded <code>github.com/warpstreamlabs/bento</code> from v1.3.1 to v1.2.0 and <br>replaced it with a fork.<br> <li> Downgraded <code>go.opentelemetry.io/otel</code> and related packages from v1.29.0 <br>to v1.24.0.<br> <li> Updated multiple indirect dependencies to earlier versions.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6700/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6">+47/-65</a>  </td> </tr> </table></td></tr><tr><td><strong>Additional files (token-limit)</strong></td><td><table> <tr> <td> <details> <summary><strong>go.sum</strong><dd><code>...</code>                                                                                                            </dd></summary> <hr> go.sum ... </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6700/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63">+103/-1054</a></td> </tr> </table></td></tr></tr></tbody></table> ___ > 💡 **PR-Agent usage**: Comment `/help "your question"` on any pull request to receive relevant information

#6697) ### **User description** PR for https://tyktech.atlassian.net/browse/TT-13508 Changes: * Bento updated to this commit: warpstreamlabs/bento@755c497 * `removeStream` uses the correct key to remove an inactive stream, not combining it with the API ID. Related PR: warpstreamlabs/bento#125 ___ ### **PR Type** Bug fix, Enhancement ___ ### **Description** - Fixed a bug in the `removeStream` function by using the correct key for removing inactive streams, ensuring that the API ID is not combined with the stream ID. - Updated the `google.golang.org/grpc` dependency to version `v1.67.0`. - Updated the `github.com/warpstreamlabs/bento` dependency to a specific commit for improved performance. - Updated several other dependencies to their latest versions to ensure compatibility and leverage new features. ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Bug fix</strong></td><td><table> <tr> <td> <details> <summary><strong>manager.go</strong><dd><code>Correct stream removal logic in `removeStream` function</code>    </dd></summary> <hr> ee/middleware/streams/manager.go <li>Fixed the <code>removeStream</code> function to use the correct key for stream <br>removal.<br> <li> Removed the combination of API ID with stream ID for stream <br>identification.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6697/files#diff-3e372b3346d8d296e6953152c89202a634d7654f10549676af9aea8628e13dfb">+2/-4</a>      </td> </tr> </table></td></tr><tr><td><strong>Dependencies</strong></td><td><table> <tr> <td> <details> <summary><strong>go.mod</strong><dd><code>Update dependencies to latest versions</code>                                      </dd></summary> <hr> go.mod <li>Updated <code>google.golang.org/grpc</code> to version <code>v1.67.0</code>.<br> <li> Updated <code>github.com/warpstreamlabs/bento</code> to a specific commit.<br> <li> Updated various dependencies to newer versions.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6697/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6">+65/-45</a>  </td> </tr> </table></td></tr><tr><td><strong>Additional files (token-limit)</strong></td><td><table> <tr> <td> <details> <summary><strong>go.sum</strong><dd><code>...</code>                                                                                                            </dd></summary> <hr> go.sum ... </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6697/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63">+1054/-103</a></td> </tr> </table></td></tr></tr></tbody></table> ___ > 💡 **PR-Agent usage**: Comment `/help "your question"` on any pull request to receive relevant information

…ick some changes from latest main branch. (#6700) ### **User description** Bento >=1.3.0 requires an OpenTelemetry upgrade and it breaks our E2E tests. Here is some details: https://tyktech.atlassian.net/browse/TT-13518 This PR downgrades Bento to v1.2.0 and cherry-picks some changes from the main branch to fix TT-13508. See this #6697 ___ ### **PR Type** enhancement, dependencies ___ ### **Description** - Downgraded `google.golang.org/grpc` from v1.67.0 to v1.66.2 to address compatibility issues. - Downgraded `github.com/warpstreamlabs/bento` from v1.3.1 to v1.2.0 and replaced it with a forked version from `github.com/TykTechnologies/bento`. - Downgraded `go.opentelemetry.io/otel` and related packages from v1.29.0 to v1.24.0 to resolve issues with OpenTelemetry upgrades. - Updated multiple indirect dependencies to earlier versions to maintain compatibility and stability. ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Dependencies</strong></td><td><table> <tr> <td> <details> <summary><strong>go.mod</strong><dd><code>Downgrade dependencies and switch to a forked Bento version</code></dd></summary> <hr> go.mod <li>Downgraded <code>google.golang.org/grpc</code> from v1.67.0 to v1.66.2.<br> <li> Downgraded <code>github.com/warpstreamlabs/bento</code> from v1.3.1 to v1.2.0 and <br>replaced it with a fork.<br> <li> Downgraded <code>go.opentelemetry.io/otel</code> and related packages from v1.29.0 <br>to v1.24.0.<br> <li> Updated multiple indirect dependencies to earlier versions.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6700/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6">+47/-65</a>  </td> </tr> </table></td></tr><tr><td><strong>Additional files (token-limit)</strong></td><td><table> <tr> <td> <details> <summary><strong>go.sum</strong><dd><code>...</code>                                                                                                            </dd></summary> <hr> go.sum ... </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6700/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63">+103/-1054</a></td> </tr> </table></td></tr></tr></tbody></table> ___ > 💡 **PR-Agent usage**: Comment `/help "your question"` on any pull request to receive relevant information

#6697) ### **User description** PR for https://tyktech.atlassian.net/browse/TT-13508 Changes: * Bento updated to this commit: warpstreamlabs/bento@755c497 * `removeStream` uses the correct key to remove an inactive stream, not combining it with the API ID. Related PR: warpstreamlabs/bento#125 ___ ### **PR Type** Bug fix, Enhancement ___ ### **Description** - Fixed a bug in the `removeStream` function by using the correct key for removing inactive streams, ensuring that the API ID is not combined with the stream ID. - Updated the `google.golang.org/grpc` dependency to version `v1.67.0`. - Updated the `github.com/warpstreamlabs/bento` dependency to a specific commit for improved performance. - Updated several other dependencies to their latest versions to ensure compatibility and leverage new features. ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Bug fix</strong></td><td><table> <tr> <td> <details> <summary><strong>manager.go</strong><dd><code>Correct stream removal logic in `removeStream` function</code>    </dd></summary> <hr> ee/middleware/streams/manager.go <li>Fixed the <code>removeStream</code> function to use the correct key for stream <br>removal.<br> <li> Removed the combination of API ID with stream ID for stream <br>identification.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6697/files#diff-3e372b3346d8d296e6953152c89202a634d7654f10549676af9aea8628e13dfb">+2/-4</a>      </td> </tr> </table></td></tr><tr><td><strong>Dependencies</strong></td><td><table> <tr> <td> <details> <summary><strong>go.mod</strong><dd><code>Update dependencies to latest versions</code>                                      </dd></summary> <hr> go.mod <li>Updated <code>google.golang.org/grpc</code> to version <code>v1.67.0</code>.<br> <li> Updated <code>github.com/warpstreamlabs/bento</code> to a specific commit.<br> <li> Updated various dependencies to newer versions.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6697/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6">+65/-45</a>  </td> </tr> </table></td></tr><tr><td><strong>Additional files (token-limit)</strong></td><td><table> <tr> <td> <details> <summary><strong>go.sum</strong><dd><code>...</code>                                                                                                            </dd></summary> <hr> go.sum ... </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6697/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63">+1054/-103</a></td> </tr> </table></td></tr></tr></tbody></table> ___ > 💡 **PR-Agent usage**: Comment `/help "your question"` on any pull request to receive relevant information

…ick some changes from latest main branch. (#6700) ### **User description** Bento >=1.3.0 requires an OpenTelemetry upgrade and it breaks our E2E tests. Here is some details: https://tyktech.atlassian.net/browse/TT-13518 This PR downgrades Bento to v1.2.0 and cherry-picks some changes from the main branch to fix TT-13508. See this #6697 ___ ### **PR Type** enhancement, dependencies ___ ### **Description** - Downgraded `google.golang.org/grpc` from v1.67.0 to v1.66.2 to address compatibility issues. - Downgraded `github.com/warpstreamlabs/bento` from v1.3.1 to v1.2.0 and replaced it with a forked version from `github.com/TykTechnologies/bento`. - Downgraded `go.opentelemetry.io/otel` and related packages from v1.29.0 to v1.24.0 to resolve issues with OpenTelemetry upgrades. - Updated multiple indirect dependencies to earlier versions to maintain compatibility and stability. ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Dependencies</strong></td><td><table> <tr> <td> <details> <summary><strong>go.mod</strong><dd><code>Downgrade dependencies and switch to a forked Bento version</code></dd></summary> <hr> go.mod <li>Downgraded <code>google.golang.org/grpc</code> from v1.67.0 to v1.66.2.<br> <li> Downgraded <code>github.com/warpstreamlabs/bento</code> from v1.3.1 to v1.2.0 and <br>replaced it with a fork.<br> <li> Downgraded <code>go.opentelemetry.io/otel</code> and related packages from v1.29.0 <br>to v1.24.0.<br> <li> Updated multiple indirect dependencies to earlier versions.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6700/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6">+47/-65</a>  </td> </tr> </table></td></tr><tr><td><strong>Additional files (token-limit)</strong></td><td><table> <tr> <td> <details> <summary><strong>go.sum</strong><dd><code>...</code>                                                                                                            </dd></summary> <hr> go.sum ... </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6700/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63">+103/-1054</a></td> </tr> </table></td></tr></tr></tbody></table> ___ > 💡 **PR-Agent usage**: Comment `/help "your question"` on any pull request to receive relevant information

TykTechnologies#6697) ### **User description** PR for https://tyktech.atlassian.net/browse/TT-13508 Changes: * Bento updated to this commit: warpstreamlabs/bento@755c497 * `removeStream` uses the correct key to remove an inactive stream, not combining it with the API ID. Related PR: warpstreamlabs/bento#125 ___ ### **PR Type** Bug fix, Enhancement ___ ### **Description** - Fixed a bug in the `removeStream` function by using the correct key for removing inactive streams, ensuring that the API ID is not combined with the stream ID. - Updated the `google.golang.org/grpc` dependency to version `v1.67.0`. - Updated the `github.com/warpstreamlabs/bento` dependency to a specific commit for improved performance. - Updated several other dependencies to their latest versions to ensure compatibility and leverage new features. ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Bug fix</strong></td><td><table> <tr> <td> <details> <summary><strong>manager.go</strong><dd><code>Correct stream removal logic in `removeStream` function</code>    </dd></summary> <hr> ee/middleware/streams/manager.go <li>Fixed the <code>removeStream</code> function to use the correct key for stream <br>removal.<br> <li> Removed the combination of API ID with stream ID for stream <br>identification.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6697/files#diff-3e372b3346d8d296e6953152c89202a634d7654f10549676af9aea8628e13dfb">+2/-4</a>      </td> </tr> </table></td></tr><tr><td><strong>Dependencies</strong></td><td><table> <tr> <td> <details> <summary><strong>go.mod</strong><dd><code>Update dependencies to latest versions</code>                                      </dd></summary> <hr> go.mod <li>Updated <code>google.golang.org/grpc</code> to version <code>v1.67.0</code>.<br> <li> Updated <code>github.com/warpstreamlabs/bento</code> to a specific commit.<br> <li> Updated various dependencies to newer versions.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6697/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6">+65/-45</a>  </td> </tr> </table></td></tr><tr><td><strong>Additional files (token-limit)</strong></td><td><table> <tr> <td> <details> <summary><strong>go.sum</strong><dd><code>...</code>                                                                                                            </dd></summary> <hr> go.sum ... </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6697/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63">+1054/-103</a></td> </tr> </table></td></tr></tr></tbody></table> ___ > 💡 **PR-Agent usage**: Comment `/help "your question"` on any pull request to receive relevant information

…ick some changes from latest main branch. (TykTechnologies#6700) ### **User description** Bento >=1.3.0 requires an OpenTelemetry upgrade and it breaks our E2E tests. Here is some details: https://tyktech.atlassian.net/browse/TT-13518 This PR downgrades Bento to v1.2.0 and cherry-picks some changes from the main branch to fix TT-13508. See this TykTechnologies#6697 ___ ### **PR Type** enhancement, dependencies ___ ### **Description** - Downgraded `google.golang.org/grpc` from v1.67.0 to v1.66.2 to address compatibility issues. - Downgraded `github.com/warpstreamlabs/bento` from v1.3.1 to v1.2.0 and replaced it with a forked version from `github.com/TykTechnologies/bento`. - Downgraded `go.opentelemetry.io/otel` and related packages from v1.29.0 to v1.24.0 to resolve issues with OpenTelemetry upgrades. - Updated multiple indirect dependencies to earlier versions to maintain compatibility and stability. ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Dependencies</strong></td><td><table> <tr> <td> <details> <summary><strong>go.mod</strong><dd><code>Downgrade dependencies and switch to a forked Bento version</code></dd></summary> <hr> go.mod <li>Downgraded <code>google.golang.org/grpc</code> from v1.67.0 to v1.66.2.<br> <li> Downgraded <code>github.com/warpstreamlabs/bento</code> from v1.3.1 to v1.2.0 and <br>replaced it with a fork.<br> <li> Downgraded <code>go.opentelemetry.io/otel</code> and related packages from v1.29.0 <br>to v1.24.0.<br> <li> Updated multiple indirect dependencies to earlier versions.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6700/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6">+47/-65</a>  </td> </tr> </table></td></tr><tr><td><strong>Additional files (token-limit)</strong></td><td><table> <tr> <td> <details> <summary><strong>go.sum</strong><dd><code>...</code>                                                                                                            </dd></summary> <hr> go.sum ... </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6700/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63">+103/-1054</a></td> </tr> </table></td></tr></tr></tbody></table> ___ > 💡 **PR-Agent usage**: Comment `/help "your question"` on any pull request to receive relevant information

TykTechnologies#6697) ### **User description** PR for https://tyktech.atlassian.net/browse/TT-13508 Changes: * Bento updated to this commit: warpstreamlabs/bento@755c497 * `removeStream` uses the correct key to remove an inactive stream, not combining it with the API ID. Related PR: warpstreamlabs/bento#125 ___ ### **PR Type** Bug fix, Enhancement ___ ### **Description** - Fixed a bug in the `removeStream` function by using the correct key for removing inactive streams, ensuring that the API ID is not combined with the stream ID. - Updated the `google.golang.org/grpc` dependency to version `v1.67.0`. - Updated the `github.com/warpstreamlabs/bento` dependency to a specific commit for improved performance. - Updated several other dependencies to their latest versions to ensure compatibility and leverage new features. ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Bug fix</strong></td><td><table> <tr> <td> <details> <summary><strong>manager.go</strong><dd><code>Correct stream removal logic in `removeStream` function</code>    </dd></summary> <hr> ee/middleware/streams/manager.go <li>Fixed the <code>removeStream</code> function to use the correct key for stream <br>removal.<br> <li> Removed the combination of API ID with stream ID for stream <br>identification.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6697/files#diff-3e372b3346d8d296e6953152c89202a634d7654f10549676af9aea8628e13dfb">+2/-4</a>      </td> </tr> </table></td></tr><tr><td><strong>Dependencies</strong></td><td><table> <tr> <td> <details> <summary><strong>go.mod</strong><dd><code>Update dependencies to latest versions</code>                                      </dd></summary> <hr> go.mod <li>Updated <code>google.golang.org/grpc</code> to version <code>v1.67.0</code>.<br> <li> Updated <code>github.com/warpstreamlabs/bento</code> to a specific commit.<br> <li> Updated various dependencies to newer versions.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6697/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6">+65/-45</a>  </td> </tr> </table></td></tr><tr><td><strong>Additional files (token-limit)</strong></td><td><table> <tr> <td> <details> <summary><strong>go.sum</strong><dd><code>...</code>                                                                                                            </dd></summary> <hr> go.sum ... </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6697/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63">+1054/-103</a></td> </tr> </table></td></tr></tr></tbody></table> ___ > 💡 **PR-Agent usage**: Comment `/help "your question"` on any pull request to receive relevant information

…ick some changes from latest main branch. (TykTechnologies#6700) ### **User description** Bento >=1.3.0 requires an OpenTelemetry upgrade and it breaks our E2E tests. Here is some details: https://tyktech.atlassian.net/browse/TT-13518 This PR downgrades Bento to v1.2.0 and cherry-picks some changes from the main branch to fix TT-13508. See this TykTechnologies#6697 ___ ### **PR Type** enhancement, dependencies ___ ### **Description** - Downgraded `google.golang.org/grpc` from v1.67.0 to v1.66.2 to address compatibility issues. - Downgraded `github.com/warpstreamlabs/bento` from v1.3.1 to v1.2.0 and replaced it with a forked version from `github.com/TykTechnologies/bento`. - Downgraded `go.opentelemetry.io/otel` and related packages from v1.29.0 to v1.24.0 to resolve issues with OpenTelemetry upgrades. - Updated multiple indirect dependencies to earlier versions to maintain compatibility and stability. ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Dependencies</strong></td><td><table> <tr> <td> <details> <summary><strong>go.mod</strong><dd><code>Downgrade dependencies and switch to a forked Bento version</code></dd></summary> <hr> go.mod <li>Downgraded <code>google.golang.org/grpc</code> from v1.67.0 to v1.66.2.<br> <li> Downgraded <code>github.com/warpstreamlabs/bento</code> from v1.3.1 to v1.2.0 and <br>replaced it with a fork.<br> <li> Downgraded <code>go.opentelemetry.io/otel</code> and related packages from v1.29.0 <br>to v1.24.0.<br> <li> Updated multiple indirect dependencies to earlier versions.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6700/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6">+47/-65</a>  </td> </tr> </table></td></tr><tr><td><strong>Additional files (token-limit)</strong></td><td><table> <tr> <td> <details> <summary><strong>go.sum</strong><dd><code>...</code>                                                                                                            </dd></summary> <hr> go.sum ... </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6700/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63">+103/-1054</a></td> </tr> </table></td></tr></tr></tbody></table> ___ > 💡 **PR-Agent usage**: Comment `/help "your question"` on any pull request to receive relevant information

buraksezer added 4 commits November 7, 2024 15:53

[TT-13508] Attempt to fix zombie connections.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

cb330bd

[TT-13508] Use the latest commit from Bento's main branch

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

aad478b

[TT-13508] StreamGCInterval is 1 minute

4e5f96e

[TT-13508] Use the correct key while stopping and removing an inactiv…

Loading
Loading status checks…

51eae92

…e stream

buraksezer requested a review from kofoworola November 8, 2024 08:40

buger added bug Tyk Product Development labels Nov 8, 2024

buraksezer requested a review from pvormste November 8, 2024 08:40

github-actions bot added the Review effort [1-5]: 4 label Nov 8, 2024

kofoworola approved these changes Nov 8, 2024

View reviewed changes

kofoworola enabled auto-merge (squash) November 8, 2024 08:58

kofoworola disabled auto-merge November 8, 2024 08:58

buraksezer enabled auto-merge (squash) November 8, 2024 09:04

[TT-13508] Implement a missing method on spanWrapper

Loading
Loading status checks…

753832a

buraksezer disabled auto-merge November 8, 2024 09:43

sredxny approved these changes Nov 8, 2024

View reviewed changes

buraksezer merged commit 79a393e into master Nov 8, 2024
27 of 40 checks passed

buraksezer deleted the fix/TT-13508/Streams-poor-performance-when-reconnecting-to-a-Streams-API branch November 8, 2024 10:59

buraksezer mentioned this pull request Nov 8, 2024

[TT-13508] Downgrade Bento to v1.2.0 and use our own fork to cherry-pick some changes from latest main branch. #6700

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TT-13508] Streams poor performance when reconnecting to a Streams API #6697

[TT-13508] Streams poor performance when reconnecting to a Streams API #6697

buraksezer commented Nov 8, 2024 •

edited by github-actions bot

Loading

buger commented Nov 8, 2024

github-actions bot commented Nov 8, 2024

github-actions bot commented Nov 8, 2024

github-actions bot commented Nov 8, 2024

sonarqubecloud bot commented Nov 8, 2024

[TT-13508] Streams poor performance when reconnecting to a Streams API #6697

[TT-13508] Streams poor performance when reconnecting to a Streams API #6697

Conversation

buraksezer commented Nov 8, 2024 • edited by github-actions bot Loading

User description

PR Type

Description

Changes walkthrough 📝

buger commented Nov 8, 2024

github-actions bot commented Nov 8, 2024

PR Reviewer Guide 🔍

github-actions bot commented Nov 8, 2024

PR Code Suggestions ✨

github-actions bot commented Nov 8, 2024

sonarqubecloud bot commented Nov 8, 2024

Quality Gate failed

buraksezer commented Nov 8, 2024 •

edited by github-actions bot

Loading