Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bashunit-e file isn't created sometimes #253

Merged
merged 2 commits into from
May 24, 2024

Conversation

fabriziofs
Copy link
Collaborator

📚 Description

Replace this text with a short description of your feature/bugfix.
Fix failing test due to the way sed command behave in macOS, sometimes the file ./bin/bashunit-e isn't created and the test fails:
image

To avoid this I've added the -f flag to the rm command to in case the ./bin/bashunit-e don't exist the command don't fail and breaks the test, doc related:
image

🔖 Changes

  • Add -f flag to avoid problems with rm command in macOS

✅ To-do list

  • I updated the CHANGELOG.md to reflect the new feature or fix
  • I updated the documentation to reflect the changes

@fabriziofs fabriziofs requested a review from Chemaclass May 24, 2024 23:02
Copy link
Member

@Chemaclass Chemaclass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Chemaclass Chemaclass added the bug Something isn't working label May 24, 2024
@Chemaclass Chemaclass merged commit 9d0d881 into main May 24, 2024
7 checks passed
@Chemaclass Chemaclass deleted the macos-file-creation-problem branch May 24, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants