Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Personal deadline remains enabled, or at least visible to teachers #13

Open
tonydelahunty opened this issue Apr 23, 2018 · 1 comment

Comments

@tonydelahunty
Copy link

tonydelahunty commented Apr 23, 2018

If :
general deadline is enabled,
and then Personal deadline is set to yes,
(even if no personal deadline values are set);
and then if (susbsequently) general deadline is switched off:

the Personal deadline setting remains at yes, for that coursework instance. If a personal deadline had not been set for that student, it shows [to teachers] as Unix null, i.e. 1.1.70. see screenshot. coursework_personaldeadlineremainsset This value can also be edited.

In this case [where a (non-null) personal deadline has been set for a student, and then the general deadline has been unset or switched off for that entire Coursework instance], the personal deadline is not visible to the student, and is seemingly not applied, i.e. the student may go to the upload submisssion screen, and select a file for upload. But at the moment of completion [i.e. "Submit and finalise"], the [non-visible] deadline is applied to prevent the submission from going through (Message: "The deadline has now passed and late submissions (or updates to existing submissions) are not allowed.")

@aspark21
Copy link
Contributor

Hi Tony,

Correct me if I'm wrong but you are keeping the Personal Deadline setting set as Yes throughout so it is indeed working as expected. The General deadline setting is only used as default value for the personal deadlines during the initial setup (it is mentioned in the helper text) of a Personal Deadline type of assignment. Setting this to not have a default deadline for a personal deadline assignment will indeed set it to the Unix default time, it is expected this must be changed for each student prior to it being opened up.

Coursework is designed to work with 3 types of deadlines:
-general deadlines => everyone has one set deadline. Can grant extensions if need be but everyone has the same deadline
-No deadline => Nobody has a deadline and can submit whenever.
-Personal Deadlines => each student has a specific deadline specific to them.

You are in the last scenario. If you were switching Personal Deadlines to "No" and the Personal Deadlines were still listed in a "No deadline" type of assignment that would be a bug but from what you are describing I don't see one.

agwells pushed a commit to catalyst/open-mod_coursework that referenced this issue Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants