Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gas test for nftManager#positions #139

Merged
merged 1 commit into from
Jun 8, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions contracts/test/NonfungiblePositionManagerPositionsGasTest.sol
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
// SPDX-License-Identifier: UNLICENSED
pragma solidity =0.7.6;

import '../NonfungiblePositionManager.sol';

contract NonfungiblePositionManagerPositionsGasTest {
NonfungiblePositionManager immutable nonfungiblePositionManager;

constructor(NonfungiblePositionManager _nonfungiblePositionManager) {
nonfungiblePositionManager = _nonfungiblePositionManager;
}

function getGasCostOfPositions(uint256 tokenId) external view returns (uint256) {
uint256 gasBefore = gasleft();
nonfungiblePositionManager.positions(tokenId);
return gasBefore - gasleft();
}
}
33 changes: 33 additions & 0 deletions test/NonfungiblePositionManager.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
IWETH9,
IUniswapV3Factory,
SwapRouter,
NonfungiblePositionManagerPositionsGasTest,
} from '../typechain'
import completeFixture from './shared/completeFixture'
import { computePoolAddress } from './shared/computePoolAddress'
Expand Down Expand Up @@ -1165,6 +1166,38 @@ describe('NonfungiblePositionManager', () => {
})
})

describe('#positions', async () => {
it('gas', async () => {
const positionsGasTestFactory = await ethers.getContractFactory('NonfungiblePositionManagerPositionsGasTest')
const positionsGasTest = (await positionsGasTestFactory.deploy(
nft.address
)) as NonfungiblePositionManagerPositionsGasTest

await nft.createAndInitializePoolIfNecessary(
tokens[0].address,
tokens[1].address,
FeeAmount.MEDIUM,
encodePriceSqrt(1, 1)
)

await nft.mint({
token0: tokens[0].address,
token1: tokens[1].address,
tickLower: getMinTick(TICK_SPACINGS[FeeAmount.MEDIUM]),
tickUpper: getMaxTick(TICK_SPACINGS[FeeAmount.MEDIUM]),
fee: FeeAmount.MEDIUM,
recipient: other.address,
amount0Desired: 15,
amount1Desired: 15,
amount0Min: 0,
amount1Min: 0,
deadline: 10,
})

await snapshotGasCost(positionsGasTest.getGasCostOfPositions(1))
})
})

describe('fees accounting', () => {
beforeEach('create two positions', async () => {
await nft.createAndInitializePoolIfNecessary(
Expand Down
2 changes: 2 additions & 0 deletions test/__snapshots__/NonfungiblePositionManager.spec.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ exports[`NonfungiblePositionManager #permit owned by eoa gas 1`] = `64528`;

exports[`NonfungiblePositionManager #permit owned by verifying contract gas 1`] = `68325`;

exports[`NonfungiblePositionManager #positions gas 1`] = `19890`;

exports[`NonfungiblePositionManager #transferFrom gas 1`] = `79091`;

exports[`NonfungiblePositionManager #transferFrom gas comes from approved 1`] = `67491`;
Expand Down