Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(infra): Setup NPM Deploy #929

Merged
merged 6 commits into from
Feb 4, 2025
Merged

chore(infra): Setup NPM Deploy #929

merged 6 commits into from
Feb 4, 2025

Conversation

mr-uniswap
Copy link
Contributor

Sets up the npm deploy. This needs a package.json file to operate before it will work

Sets up the npm deploy
@mr-uniswap mr-uniswap requested a review from a team as a code owner January 8, 2025 21:49
- name: Install Foundry
uses: foundry-rs/foundry-toolchain@v1
with:
version: nightly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh and can you change this to stable, and do you mind changing nightly to stable in all the other CIs?
nightly foundry has caused us some issues recently

@mr-uniswap mr-uniswap closed this Jan 17, 2025
@mr-uniswap mr-uniswap deleted the chore/npm-deploy branch January 17, 2025 21:02
@mr-uniswap mr-uniswap restored the chore/npm-deploy branch January 17, 2025 21:34
@mr-uniswap mr-uniswap reopened this Jan 17, 2025
@gretzke
Copy link
Contributor

gretzke commented Feb 4, 2025

@mr-uniswap don't we want to use provenance for this package, too?

@mr-uniswap
Copy link
Contributor Author

@mr-uniswap don't we want to use provenance for this package, too?

Yes, we do, but that gets set in the package.json file when you all have it ready in your publish config:

  "publishConfig": {
    "access": "public",
    "provenance": true
  },

@mr-uniswap mr-uniswap merged commit c4b27fa into main Feb 4, 2025
5 checks passed
@mr-uniswap mr-uniswap deleted the chore/npm-deploy branch February 4, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants