Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2eテストが落ちたらhtmlで見れるようにしました #1516

Merged
merged 12 commits into from
Aug 22, 2023
Merged

e2eテストが落ちたらhtmlで見れるようにしました #1516

merged 12 commits into from
Aug 22, 2023
+22 −2

Conversation

stmtk1
Copy link
Contributor

@stmtk1 stmtk1 commented Aug 22, 2023 •
edited
Loading

内容

e2eテストが落ちた際に、落ちた際の挙動が見れる動画を埋め込んだhtmlを出力するようにしました。

関連 Issue

close #1506

スクリーンショット・動画など

その他

@stmtk1 stmtk1 requested a review from a team as a code owner August 22, 2023 04:58
@stmtk1 stmtk1 requested review from Hiroshiba and removed request for a team August 22, 2023 04:58
@stmtk1 stmtk1 marked this pull request as draft August 22, 2023 04:58
@stmtk1
Copy link
Contributor Author

stmtk1 commented Aug 22, 2023 •
edited
Loading

htmlをgithub上でダウンロードできるようにしました

@stmtk1 stmtk1 marked this pull request as ready for review August 22, 2023 06:53
Hiroshiba
Hiroshiba reviewed Aug 22, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

プルリクエストありがとうございます、非常に素晴らしいです！！！

1つ確認したいことがあってコメントしてみました！

📝 マージ前の自分へメモ：名称とか改行とか整えても良いかも

@stmtk1 stmtk1 requested a review from Hiroshiba August 22, 2023 19:08
Hiroshiba
Hiroshiba approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！！

ちょっと細かい調整だけコミットさせていただいてマージさせていただこうと思います！！

@Hiroshiba Hiroshiba merged commit 0648f78 into VOICEVOX:main Aug 22, 2023
@stmtk1 stmtk1 deleted the e2e-html branch August 23, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Github Actionsでe2eテストが落ちたレポート結果を動画で見れるようにする
2 participants
@stmtk1 @Hiroshiba