Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: startTime === 0のフレーズでピッチがレンダリングされないのを修正 #1894

Merged
merged 1 commit into from
Mar 3, 2024
Merged

Fix: startTime === 0のフレーズでピッチがレンダリングされないのを修正 #1894

merged 1 commit into from
Mar 3, 2024

Conversation

sigprogramming
Copy link
Contributor

内容

startTime === 0のフレーズでピッチがレンダリングされないバグを修正します。

関連 Issue

close #1889

その他

@sigprogramming sigprogramming requested a review from a team as a code owner March 3, 2024 06:25
@sigprogramming sigprogramming requested review from Hiroshiba and removed request for a team March 3, 2024 06:25
Hiroshiba
Hiroshiba approved these changes Mar 3, 2024
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

javascriptのfalsyは結構危ういので、ちゃんと!=undefinedと書いた方が良いっぽいなと感じました。
たしかeslint ruleがあるので導入しても良いかもですね…！

@Hiroshiba Hiroshiba merged commit 344ae89 into VOICEVOX:main Mar 3, 2024
9 checks passed
@sigprogramming sigprogramming deleted the fix_pitch_rendering_bug branch March 3, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1.5小節目からノートを配置するとピッチがレンダリングされない
2 participants
@sigprogramming @Hiroshiba