Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ソング：レンダリング順を改善 #1909

Merged
merged 13 commits into from
Mar 18, 2024
Merged

ソング：レンダリング順を改善 #1909

merged 13 commits into from
Mar 18, 2024

Conversation

sevenc-nanashi
Copy link
Member

@sevenc-nanashi sevenc-nanashi commented Mar 6, 2024 •
edited
Loading

内容

ソングエディタのレンダリング順を良い感じにします。

関連 Issue

スクリーンショット・動画など

sozai.vvproj.-.VOICEVOX.-.Ver.999.999.999.ubuntu.2024-03-06.19-41-38.mp4

その他

実際の優先順はdoc commentをみてもらえれば

@sevenc-nanashi sevenc-nanashi requested a review from a team as a code owner March 6, 2024 10:42
@sevenc-nanashi sevenc-nanashi requested review from Hiroshiba and removed request for a team March 6, 2024 10:42
@Hiroshiba Hiroshiba requested a review from sigprogramming March 6, 2024 14:56
sevenc-nanashi and others added 3 commits March 7, 2024 00:23
@sevenc-nanashi
Fix: toEqualを使う
9774e02
@Hiroshiba @sevenc-nanashi
音域補正用のパラメーターを増やしつつ、開発時のみの機能に (VOICEVOX#1902)
e6fc82a 
* 音高補正にしつつ開発時のみ機能に

* VoiceKey→GuidePitch

* とりあえず実装としては完成

* keyRangeAdjustmentに

* (note|guide)KeyShiftを消し、補正→調整にする

* keyShiftを全てKeyRangeAdjustmentへ
@sevenc-nanashi
Update: mainに追従
1ff8b6d
Hiroshiba
Hiroshiba reviewed Mar 6, 2024
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あ、追従がmerge mainじゃなくてcherry pickっぽくなってて差分が複雑になっちゃってるかもです！

@sevenc-nanashi
Copy link
Member Author

多分直ったはず？

Hiroshiba
Hiroshiba reviewed Mar 7, 2024
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほぼLGTMです！！良い感じ！！！

@sigprogramming にもレビューもらえると心強いです🙇

src/sing/domain.ts Outdated

/**
* 次にレンダリングするべきPhraseを探す。
* 存在しない場合は[undefined, undefined]を返す。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

まーーー変数定義が必要にはなりますが、たぶんundefinedを返す実装のがスマートですかねぇ。
将来値増やそうとした時とかに壊れていきそうですし。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

エラーを投げるようにしました（どちらでもよさそう）

sigprogramming
sigprogramming approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@sigprogramming sigprogramming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです！！
実装ありがとうございます！

Hiroshiba
Hiroshiba approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

ツイートしようかなと思います 🙏
ちなみに、なんとなく10RT行きそうであればツイート、くらいの気持ちで運用しています。

@Hiroshiba Hiroshiba merged commit 102d8a9 into VOICEVOX:main Mar 18, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

@sigprogramming sigprogramming sigprogramming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ソング：再生ヘッドに近いフレーズから生成するようにする
3 participants
@sevenc-nanashi @Hiroshiba @sigprogramming