Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: scriptsを整理 #2514

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Conversation

sevenc-nanashi
Copy link
Member

内容

package.jsonのscripts欄を整理します。

関連 Issue

(なし)

スクリーンショット・動画など

(なし)

その他

(なし)

@sevenc-nanashi sevenc-nanashi requested a review from a team as a code owner January 30, 2025 00:20
@sevenc-nanashi sevenc-nanashi requested review from Hiroshiba and removed request for a team January 30, 2025 00:20
@voicevox-preview-pages
Copy link

🚀 プレビュー用ページを作成しました 🚀

更新時点でのコミットハッシュ:3142f64

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

良いですね!!
ライセンス生成もうちょっと下でも良いかもと思ったけど、どのスクリプトから利用されるかわからないしこの位置が良さそう感。

テストの並び順は粒度が低い順で unit > storybook > browser > electron でも良いかもと思ったけど、まあそこまで気にしなくても良さそう!

改行区切りがクールでいいですね!
マージします!!

@Hiroshiba Hiroshiba enabled auto-merge January 30, 2025 00:50
@Hiroshiba Hiroshiba added this pull request to the merge queue Jan 30, 2025
@sevenc-nanashi
Copy link
Member Author

気持ちとしては

  • Lint系
  • tools下を実行する系
  • テスト
  • ビルド
  • Lifecycle script

です。

Merged via the queue into VOICEVOX:main with commit a12d9ca Jan 30, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants