refactor: getAppVersion()をなくす #2538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 11 changed files in this pull request and generated no comments.
Files not reviewed (6)
- src/components/Dialog/HelpDialog/HelpDialog.vue: Evaluated as low risk
- src/components/Dialog/UpdateNotificationDialog/Container.vue: Evaluated as low risk
- src/components/Menu/MenuBar/MenuBar.vue: Evaluated as low risk
- src/backend/browser/sandbox.ts: Evaluated as low risk
- src/composables/useFetchNewUpdateInfos.ts: Evaluated as low risk
- src/backend/electron/main.ts: Evaluated as low risk
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ： |
|
レビューありがとうございます、マージします！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
たぶんwindow.backendからこの関数を省いても問題ないと思うので省き、ついでにipc通信からも省きます。
おそらく、最初期の実装だとelectron側から持ってこないといけなかった･･･？
今は直でVITEから得れば良い気がします。
その他
のレビュー時に思い当たりました。