chore: FlatConfigにしたら出るエラーをいくつか解消 #2564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ： |
Hiroshiba
commented
Feb 25, 2025
Comment on lines
-1548
to
+1551
| const base64Encoder = (blob: Blob): Promise<string | undefined> => { | ||
| return new Promise((resolve, reject) => { | ||
| const reader = new FileReader(); | ||
| reader.onload = () => { | ||
| // string/undefined以外が来ることはないと思うが、型定義的にArrayBufferも来るので、toStringする | ||
| const result = reader.result?.toString(); | ||
| if (result) { | ||
| // resultの中身は、"data:audio/wav;base64,<content>"という形なので、カンマ以降を抜き出す | ||
| resolve(result.slice(result.indexOf(",") + 1)); | ||
| } else { | ||
| reject(); | ||
| } | ||
| }; | ||
| reader.readAsDataURL(blob); | ||
| }); | ||
| const base64Encoder = async (blob: Blob): Promise<string> => { | ||
| const arrayBuffer = await blob.arrayBuffer(); | ||
| return toBase64(new Uint8Array(arrayBuffer)); |
There was a problem hiding this comment.
fast-base64使って簡単にしました。
一応これでここのコード（音声を全て繋げて保存）が動くことは確認しました。
|
@sevenc-nanashi |
|
レビューありがとうございます！！ マージします！！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
@MT224244 さんが
でeslintをflat configにしてくださっています。
このPRをマージするといくつかエラーが出るので、それだけ解決しました。
一旦mainブランチに向けてPR出してますが、mainブランチでエラーになりそうだったら #2560 に向けてPR出そうと思います。
関連 Issue
ref #2560
その他