Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: onetimeWatchのコールバックの引数の名前順序が逆 #2565

Conversation

Hiroshiba
Copy link
Member

@Hiroshiba Hiroshiba commented Feb 25, 2025

内容

タイトルのとおりです。
まあ引数名の順序が逆なだけなので動作に影響はないのですが、間違って使ってしまうと危ない気がしたので正しい順序にします。

その他

現状使ってるのはこの2箇所だけで、どちらも動作に問題ないはず。

onetimeWatch(
() => props.isProjectFileLoaded,
async (isProjectFileLoaded) => {
if (isProjectFileLoaded == "waiting" || !props.isEnginesReady)

onetimeWatch(
() => props.isProjectFileLoaded,
async (isProjectFileLoaded) => {

@Hiroshiba Hiroshiba requested a review from a team as a code owner February 25, 2025 18:01
@Hiroshiba Hiroshiba requested review from sevenc-nanashi and removed request for a team February 25, 2025 18:02
@voicevox-preview-pages
Copy link

voicevox-preview-pages bot commented Feb 25, 2025

🚀 プレビュー用ページを作成しました 🚀

更新時点でのコミットハッシュ:ab31a6f

Copy link
Member

@sevenc-nanashi sevenc-nanashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそう。

(ついでにコメントも直していいかも?)

@Hiroshiba
Copy link
Member Author

レビューありがとうございます!!

ほんとだ、コメントちょっと実態とずれてますね。ついでに変更します!

@Hiroshiba Hiroshiba enabled auto-merge February 26, 2025 03:08
@Hiroshiba
Copy link
Member Author

たぶん大丈夫だと思うのでマージします!

@Hiroshiba Hiroshiba added this pull request to the merge queue Feb 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 26, 2025
@Hiroshiba Hiroshiba added this pull request to the merge queue Feb 26, 2025
Merged via the queue into main with commit 02b52d8 Feb 26, 2025
19 checks passed
@Hiroshiba Hiroshiba deleted the chore-onetimeWatchのコールバックの引数の名前順序が逆 branch February 26, 2025 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants