-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: 依存関係を更新 #2598
chore: 依存関係を更新 #2598
Conversation
@@ -223,7 +223,7 @@ export type IpcIHData = { | |||
|
|||
READ_FILE: { | |||
args: [obj: { filePath: string }]; | |||
return: Result<ArrayBuffer>; | |||
return: Result<Uint8Array>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uint8Arrayの方が色々と都合が良かったのでArrayBufferからUint8Arrayにしました。
🚀 プレビュー用ページを作成しました 🚀 更新時点でのコミットハッシュ: |
e87229a
to
38968ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ほぼLGTMです!!!!
変更ありがとうございます、めちゃありがたいです!!!!
このあたりに謎のwarningが出てそうでした!!
https://github.com/VOICEVOX/voicevox/pull/2598/files#diff-9eab031a0cb78b7a7a4a8d6607e3dd64a908a8b26f5e923607c03844fc57afeb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
内容
pixi.jsを除いて依存関係を更新します。
関連 Issue
(なし)
スクリーンショット・動画など
(なし)
その他
(なし)