Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 依存関係を更新 #2598

Merged
merged 11 commits into from
Mar 8, 2025

Conversation

sevenc-nanashi
Copy link
Member

内容

pixi.jsを除いて依存関係を更新します。

関連 Issue

(なし)

スクリーンショット・動画など

(なし)

その他

(なし)

@sevenc-nanashi sevenc-nanashi requested a review from a team as a code owner March 6, 2025 12:14
@sevenc-nanashi sevenc-nanashi requested review from Hiroshiba and removed request for a team March 6, 2025 12:14
@@ -223,7 +223,7 @@ export type IpcIHData = {

READ_FILE: {
args: [obj: { filePath: string }];
return: Result<ArrayBuffer>;
return: Result<Uint8Array>;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uint8Arrayの方が色々と都合が良かったのでArrayBufferからUint8Arrayにしました。

@voicevox-preview-pages
Copy link

voicevox-preview-pages bot commented Mar 6, 2025

🚀 プレビュー用ページを作成しました 🚀

更新時点でのコミットハッシュ:6723fbd

@sevenc-nanashi sevenc-nanashi force-pushed the chore/update-deps-20250306 branch from e87229a to 38968ad Compare March 7, 2025 05:52
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほぼLGTMです!!!!
変更ありがとうございます、めちゃありがたいです!!!!

このあたりに謎のwarningが出てそうでした!!
https://github.com/VOICEVOX/voicevox/pull/2598/files#diff-9eab031a0cb78b7a7a4a8d6607e3dd64a908a8b26f5e923607c03844fc57afeb

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@Hiroshiba Hiroshiba enabled auto-merge March 8, 2025 21:24
@Hiroshiba Hiroshiba added this pull request to the merge queue Mar 8, 2025
Merged via the queue into VOICEVOX:main with commit bc06f9f Mar 8, 2025
12 checks passed
sevenc-nanashi added a commit to sevenc-nanashi/voicevox that referenced this pull request Mar 9, 2025
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants