Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] OD-2049, rma: prevent the creation of zero qty moves #3

Open
wants to merge 2 commits into
base: OD-1276/vanmoof_rma/product_replacement
Choose a base branch
from
Open

[IMP] OD-2049, rma: prevent the creation of zero qty moves #3

wants to merge 2 commits into from

Conversation

StefanRijnhart
Copy link

No description provided.

@StefanRijnhart StefanRijnhart force-pushed the OD-2049/no_zero_qty_moves branch from 3b264aa to 4310c18 Compare June 11, 2022 10:08
@StefanRijnhart StefanRijnhart force-pushed the OD-2049/no_zero_qty_moves branch from 1ae9949 to ecbe558 Compare June 15, 2022 15:05
@StefanRijnhart
[FIX] OD-2049, prevent default stock rules from kicking in
a7cb915 
If the operation type was misconfigured, or not fully configured with a route
with all the necessary rules for the right warehouse and location, default
pull rules would kick in and create the incoming customer RMA transfer
from the resupply warehouse rather than from the customer location.

With the fix in place, it turned out that the test setup for the supplier rma
test was actually creating a customer RMA. Several of the related fixes were
backported from the upstream migration to 13.0 (
ForgeFlow@f3c1a1c#diff-eba7de7269c94075cf9219526202f209b01cf3f4107e46fcce83739d2749faf5
)
@StefanRijnhart StefanRijnhart force-pushed the OD-2049/no_zero_qty_moves branch from ecbe558 to a7cb915 Compare June 15, 2022 15:15
@StefanRijnhart
Copy link
Author

StefanRijnhart commented Jun 15, 2022 •
edited
Loading

Please re-review due to the increased scope of the ticket (see second commit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonioburic antonioburic antonioburic approved these changes

@pankk pankk pankk approved these changes

@dkubiak789 dkubiak789 dkubiak789 approved these changes

@astirpe astirpe astirpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@StefanRijnhart @antonioburic @pankk @dkubiak789 @astirpe