Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change all stands to polygons #406

Merged
merged 22 commits into from
Jul 16, 2024
Merged

Change all stands to polygons #406

merged 22 commits into from
Jul 16, 2024

Conversation

Atriusftw
Copy link
Collaborator

@Atriusftw Atriusftw commented Jul 15, 2024

ENBR

image

ENVA

image

ENTO

image

ENZV

image

ENGM

image
image
image
image

Closes #383

@Atriusftw Atriusftw changed the title Change all stands to polygons WIP: Change all stands to polygons Jul 15, 2024
COORD:N063.27.16.766:E010.55.13.428
COORD:N063.27.19.119:E010.55.13.562
COORD:N063.27.19.124:E010.55.10.403
COORD:N063.27.16.798:E010.55.10.308
CODE:C
ADEP:EN
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these stands domestic only? They dont have a connection to the terminal?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to check that. Might be flex stands, but i have never seen them actually used.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are referring to stand 38 and 39, right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct

Comment on lines +1236 to +1241
STAND:ENGM:319
COORD:N060.12.03.017:E011.04.36.683
COORD:N060.12.02.105:E011.04.36.849
COORD:N060.12.01.909:E011.04.31.987
COORD:N060.12.02.832:E011.04.31.877
COORD:N060.12.03.017:E011.04.36.683
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to test the position of this polygon somewhat. Either it's a bit off or the label should be moved.

@Atriusftw Atriusftw changed the title WIP: Change all stands to polygons Change all stands to polygons Jul 16, 2024
@Atriusftw Atriusftw marked this pull request as ready for review July 16, 2024 13:26
@Atriusftw
Copy link
Collaborator Author

This PR is now ready for review and merging.

@Adrian2k
Copy link
Collaborator

Adrian2k commented Jul 16, 2024

So these stands that are spaced out from each other I would probably make it non overlapping as done with 171 and 171L.

Since if someone park on 208R, 203L, 201L even with a B738, it would most likely block the other stands regardless. If they spawn on 208, it might misdetect them on 208R and therefore also blocking 207.

If this made sense?

image

It is not possible to do this everywhere, for example at ENVA with stand 40 and 40L

COORD:N060.13.10.278:E011.06.14.135
COORD:N060.13.08.843:E011.06.11.886
COORD:N060.13.09.540:E011.06.10.148
COORD:N060.13.10.963:E011.06.12.343
USE:M
PRIORITY:-3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would remove autoassignment here - would be very weird to park someone here based on automatic stand assignment.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to manual in 8fb4d46.

@Adrian2k
Copy link
Collaborator

image

Not sure if pilot just overshoot or not.. But could probably be adjusted a bit.
Attached is the original file used for creating stands on ENGM, can be used for adjustment if you want.

Stands.zip

@Atriusftw
Copy link
Collaborator Author

So these stands that are spaced out from each other I would probably make it non overlapping as done with 171 and 171L.

Since if someone park on 208R, 203L, 201L even with a B738, it would most likely block the other stands regardless. If they spawn on 208, it might misdetect them on 208R and therefore also blocking 207.

If this made sense?

image

It is not possible to do this everywhere, for example at ENVA with stand 40 and 40L

See if these changes from 672fbc8 works better.

image

@Adrian2k
Copy link
Collaborator

Looks quite abit better, can same be done with 188/189?

@Atriusftw
Copy link
Collaborator Author

image

Not sure if pilot just overshoot or not.. But could probably be adjusted a bit. Attached is the original file used for creating stands on ENGM, can be used for adjustment if you want.

Stands.zip

Fixed in a0ea962 now.

image

@Atriusftw
Copy link
Collaborator Author

Looks quite abit better, can same be done with 188/189?

They are quite close together, but i've made an adjustment in e266fdc now.

image

Copy link
Collaborator

@Adrian2k Adrian2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, lots of changes but I think it should be all good now 👍🏻

@Adrian2k Adrian2k merged commit a339966 into main Jul 16, 2024
@Atriusftw Atriusftw deleted the stands-to-polygons branch July 16, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Covnvert all GRPlugin stands to polygons
2 participants