-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Resolved booking mismatch & updated react to CR #30
Conversation
chore: Update react, astro and dependencies.
This is amazing ❤️ I'll review it locally when we have the event this evening to check if it works as intended, if so - merge it |
Just worked a bit more on the component and I'm refactoring/rewriting the code for better readability etc. (Will come in a later PR). Just keep an eye on react-snowfall. It worked when I did this PR then when I moved from Codespaces to local environment it kept throwing dependency errors, as it seems the package.json for it isn't updated.
I've however tested it with react-19 without issues. May make a fork of it to update the dependencies. |
@Dunkstormen Could you use |
@blt950 I can see my latest commit has sneaked in here. Just so you're aware it refs the new component which is not fully done yet. So please either ignore latest commit or wait for me to be done with the full refactoring. |
@Dunkstormen No problem. Everything seems to work as of now. So I'm merging this and then refactor can be it's own PR |
I think we need to fix the dependencies @Dunkstormen , the build failed
|
@blt950 I've made a PR on the react-snowfall repo. Hoping it may be updated. Otherwise we may fallback to copying the source code into the project. Will look further into once I'm fully done with the rewrite of the BookingComponent. Only missing calling the new API endpoint which I want to avoid calling each time we're trying to match a callsign to a position. |
Updating packages, dependencies etc. for React 19.
Fixed sort and merging of online/booked positions in the BookingComponent which solves #21.