parse_lines: Fix partial reads from Linux /porc #4108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Byte order mark detection from `utfbom` would only read 4 bytes, breaking some reads from `/proc`, e.g. `/proc/sys/kernel/tainted`. parse_lines operates with byte-encoded strings, so only the BOM codepoint's UTF-8 encoding should be interesting. Moving it into processing of individual lines, after the bufio.Scanner's buffer has been filled, ensures that it does not cause extra read operations. Close Velocidex#4106
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Byte order mark detection from
utfbomwould only read 4 bytes, breaking some reads from/proc, e.g./proc/sys/kernel/tainted.parse_lines operates with byte-encoded strings, so only the BOM codepoint's UTF-8 encoding should be interesting. Moving it into processing of individual lines, after the bufio.Scanner's buffer has been filled, ensures that it does not cause extra read operations.
Close #4106